You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by kinfkong <gi...@git.apache.org> on 2014/06/05 09:59:45 UTC
[GitHub] cordova-plugin-camera pull request: Fix the bug in CDVCamera.m of ...
GitHub user kinfkong opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/30
Fix the bug in CDVCamera.m of hasPendingOperation property when takePict...
When the operation of takePiture begin, we should set hasPendingOperation to YES, when it ends, we should set that property to NO.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kinfkong/cordova-plugin-camera master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-camera/pull/30.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #30
----
commit eb1f53a0245f0e755d822f1e7230d515cb90ab2a
Author: Wang Jinggang <ki...@126.com>
Date: 2014-06-05T07:56:45Z
Fix the bug in CDVCamera.m of hasPendingOperation property when takePicture
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-camera pull request: Fix the bug in CDVCamera.m of ...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/30#issuecomment-55669337
Filed: https://issues.apache.org/jira/browse/CB-7558
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-camera pull request: Fix the bug in CDVCamera.m of ...
Posted by jsoref <gi...@git.apache.org>.
Github user jsoref commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/30#issuecomment-52078764
@kinfkong please see:
http://wiki.apache.org/cordova/ContributorWorkflow (ICLA)
http://wiki.apache.org/cordova/IssueWorkflow (file a bug in jira; include bug id and meaningful description of change in commit message)
Note that `CDVCamera.m` isn't really important to anyone, what's important is `CDVCamera:: takePicture` (assuming that's where the problem is) -- so that is what you should mention in your bug/commit message.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-camera pull request: Fix the bug in CDVCamera.m of ...
Posted by agrieve <gi...@git.apache.org>.
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/30#issuecomment-47379940
Patch looks good, but wondering if this fixes a bug?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-camera pull request: Fix the bug in CDVCamera.m of ...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/30#issuecomment-55669567
Trivial fix, pulled in: https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-camera.git;h=513bfde
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---