You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/03/20 08:36:12 UTC
[GitHub] [skywalking] limfriend opened a new issue #4545: add error
log(log4j, logback) to span log event
limfriend opened a new issue #4545: add error log(log4j,logback) to span log event
URL: https://github.com/apache/skywalking/issues/4545
Please answer these questions before submitting your issue.
- Why do you submit this issue?
- [ ] Question or discussion
- [ ] Bug
- [ ] Requirement
- [x] Feature or performance improvement
___
### Requirement or improvement
It is difficulty to correlate log and tracing.
Finding tracing by traceId often fails because sampling is turned on.
if we record important log (such as error log or warning log) in tracing . it is easy to find what is problem in our service with sky walking.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4545: add error log(log4j,
logback) to span log event
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4545: add error log(log4j,logback) to span log event
URL: https://github.com/apache/skywalking/issues/4545#issuecomment-601622203
Also, if you add this, ithere is a potential performance and network impact. Be careful.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4545: add error log(log4j,
logback) to span log event
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4545: add error log(log4j,logback) to span log event
URL: https://github.com/apache/skywalking/issues/4545#issuecomment-601621796
Then you should consider to add a log plugin. We are welcome to take this as an optional plugin.
Based on our community principle, people contribute the featured they want.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4545: add error log(log4j,
logback) to span log event
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4545: add error log(log4j,logback) to span log event
URL: https://github.com/apache/skywalking/issues/4545#issuecomment-601588009
I don't think there is much different, if you open sampling at the agent side, then the logs still are ignored like the traceid. They are sharing the same context basically.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] limfriend commented on issue #4545: add error
log(log4j, logback) to span log event
Posted by GitBox <gi...@apache.org>.
limfriend commented on issue #4545: add error log(log4j,logback) to span log event
URL: https://github.com/apache/skywalking/issues/4545#issuecomment-601618840
> I don't think there is much different, if you open sampling at the agent side, then the logs still are ignored like the traceid. They are sharing the same context basically.
It is very easy to find errors in the existing system, and tracing through the error log is a hundred times only successful once when the sampling rate is 1%.
It is easy to find error log in skywalking if we add error log to span event.
It is a hundred times only successful once with error traceId when the sampling rate is 1%.
We only need to care about which tracings are recorded abnormally, rather than looking for which records from all records one by one.
Just care about the recorded error span, not all the errors in the log, is efficient way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] limfriend opened a new issue #4545: add error
log(log4j, logback) to span log event
Posted by GitBox <gi...@apache.org>.
limfriend opened a new issue #4545: add error log(log4j,logback) to span log event
URL: https://github.com/apache/skywalking/issues/4545
Please answer these questions before submitting your issue.
- Why do you submit this issue?
- [ ] Question or discussion
- [ ] Bug
- [ ] Requirement
- [x] Feature or performance improvement
___
### Requirement or improvement
It is difficulty to correlate log and tracing.
Finding tracing by traceId often fails because sampling is turned on.
if we record important log (such as error log or warning log) in tracing . it is easy to find what is problem in our service with sky walking.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng closed issue #4545: add error log(log4j,
logback) to span log event
Posted by GitBox <gi...@apache.org>.
wu-sheng closed issue #4545: add error log(log4j,logback) to span log event
URL: https://github.com/apache/skywalking/issues/4545
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services