[jira] [Created] (OOZIE-2914) Consolidate Trim

["Peter Cseh (JIRA)" <ji...@apache.org>]

Peter Cseh created OOZIE-2914:
---------------------------------

             Summary: Consolidate Trim 
                 Key: OOZIE-2914
                 URL: https://issues.apache.org/jira/browse/OOZIE-2914
             Project: Oozie
          Issue Type: Bug
            Reporter: Peter Cseh


There are some [tTrim] functions across our codebase:
{code}
171-     * @return the formatted time string.
>> [350] 14:20 : oozie (cdh6.x) :: ack -C8 --type=java "[tT]rim\(String"
core/src/main/java/org/apache/oozie/action/hadoop/CredentialsProviderFactory.java
89-    }
90-
91-    /**
92-     * To trim string
93-     *
94-     * @param str
95-     * @return trim string
96-     */
97:    public String trim(String str) {
98-        if (str != null) {
99-            str = str.replaceAll("\\n", "");
100-            str = str.replaceAll("\\t", "");
101-            str = str.trim();
102-        }
103-        return str;
104-    }
105-}

core/src/main/java/org/apache/oozie/action/hadoop/DistcpActionExecutor.java
81-    }
82-
83-    /**
84-     * To trim string
85-     *
86-     * @param str
87-     * @return trim string
88-     */
89:    public static String Trim(String str) {
90-        if (str != null) {
91-            str = str.replaceAll("\\n", "");
92-            str = str.replaceAll("\\t", "");
93-            str = str.trim();
94-        }
95-        return str;
96-    }
97-
{code}

The purpose of these functions is to clean up input from xml files.
They should be consolidated to one place. 
There might be a similar method in Hadoop, we should use that.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)