You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/02/10 09:06:21 UTC

[GitHub] [spark] HyukjinKwon commented on a change in pull request #27452: [SPARK-30719][SQL] do not log warning if AQE is intentionally skipped and add a config to force apply

HyukjinKwon commented on a change in pull request #27452: [SPARK-30719][SQL] do not log warning if AQE is intentionally skipped and add a config to force apply
URL: https://github.com/apache/spark/pull/27452#discussion_r376935240
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
 ##########
 @@ -358,6 +358,14 @@ object SQLConf {
     .booleanConf
     .createWithDefault(false)
 
+  val ADAPTIVE_EXECUTION_FORCE_APPLY = buildConf("spark.sql.adaptive.forceApply")
 
 Review comment:
   Then why don't we make it a feature name and add `.enabled` to be consistent?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org