You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2020/07/29 07:44:59 UTC
[GitHub] [ignite] Vladsz83 commented on a change in pull request #7977: Ignite 13040
Vladsz83 commented on a change in pull request #7977:
URL: https://github.com/apache/ignite/pull/7977#discussion_r461397699
##########
File path: modules/core/src/test/java/org/apache/ignite/internal/IgniteClientRejoinTest.java
##########
@@ -354,12 +354,12 @@ public void testClientsReconnectDisabled() throws Exception {
*/
private class DiscoverySpi extends TcpDiscoverySpi {
/** {@inheritDoc} */
- @Override protected void writeToSocket(Socket sock, TcpDiscoveryAbstractMessage msg, byte[] data,
- long timeout) throws IOException {
+ @Override protected void writeToSocket(Socket sock, byte[] data,
Review comment:
@aleksey-kurinov , should it get on-lined?
##########
File path: modules/core/src/test/java/org/apache/ignite/internal/IgniteDiscoveryMassiveNodeFailTest.java
##########
@@ -301,15 +301,23 @@ public void testRecoveryOnDisconnect() throws Exception {
*
*/
private class FailDiscoverySpi extends TcpDiscoverySpi {
- /** {@inheritDoc} */
- @Override protected void writeToSocket(Socket sock, TcpDiscoveryAbstractMessage msg, byte[] data,
+ /**
+ * Writes message to the socket.
+ *
+ * @param sock Socket.
+ * @param msg Message.
Review comment:
@aleksey-kurinov , why replaced the inherited doc?
##########
File path: modules/core/src/test/java/org/apache/ignite/internal/processors/cache/distributed/dht/IgniteCacheTopologySplitAbstractTest.java
##########
@@ -217,14 +217,13 @@ protected void checkSegmented(InetSocketAddress sockAddr, long timeout) throws S
/** {@inheritDoc} */
@Override protected void writeToSocket(
- Socket sock,
- TcpDiscoveryAbstractMessage msg,
- byte[] data,
- long timeout
+ Socket sock,
+ byte[] data,
Review comment:
@aleksey-kurinov , this change looks like extra tabulation.
##########
File path: modules/core/src/test/java/org/apache/ignite/spi/discovery/tcp/BlockTcpDiscoverySpi.java
##########
@@ -74,8 +74,16 @@ private synchronized void apply(ClusterNode addr, TcpDiscoveryAbstractMessage ms
clo.apply(addr, delegate);
}
- /** {@inheritDoc} */
- @Override protected void writeToSocket(
+ /**
+ * Writes message to the socket.
+ *
+ * @param sock Socket.
Review comment:
Why replaced the inherited doc?
##########
File path: modules/core/src/test/java/org/apache/ignite/spi/discovery/tcp/TcpClientDiscoverySpiFailureTimeoutSelfTest.java
##########
@@ -449,7 +449,7 @@ public void clientReconnectOnCoordinatorRouterFail(int srvNodes) throws Exceptio
private Exception err;
/** */
- @Override protected void writeToSocket(
Review comment:
Why removed `@Override` ?
##########
File path: modules/core/src/test/java/org/apache/ignite/spi/discovery/tcp/TcpClientDiscoverySpiSelfTest.java
##########
@@ -2578,15 +2578,23 @@ private void pauseResumeOperation(boolean isPause, AtomicBoolean... locks) {
afterWrite.apply(msg, sock);
}
- /** {@inheritDoc} */
Review comment:
Why replaced the inherited doc?
##########
File path: modules/core/src/test/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoveryCoordinatorFailureTest.java
##########
@@ -273,8 +273,16 @@ public void awaitDrop() throws InterruptedException, IgniteCheckedException {
throw new IgniteCheckedException("Failed to wait for NodeAddFinishedMessage");
}
- /** {@inheritDoc} */
Review comment:
Why replaced the inherited doc?
##########
File path: modules/core/src/test/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoveryFailedJoinTest.java
##########
@@ -200,10 +200,10 @@ private void assertStartFailed(final String name) {
*/
private static class DropTcpDiscoverySpi extends TcpDiscoverySpi {
/** {@inheritDoc} */
- @Override protected void writeToSocket(Socket sock, TcpDiscoveryAbstractMessage msg, byte[] data,
Review comment:
Looks like to be on-lined.
##########
File path: modules/core/src/test/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoveryFailedJoinTest.java
##########
@@ -200,10 +200,10 @@ private void assertStartFailed(final String name) {
*/
private static class DropTcpDiscoverySpi extends TcpDiscoverySpi {
/** {@inheritDoc} */
- @Override protected void writeToSocket(Socket sock, TcpDiscoveryAbstractMessage msg, byte[] data,
- long timeout) throws IOException {
+ @Override protected void writeToSocket(Socket sock, byte[] data,
+ long timeout) throws IOException {
Review comment:
Looks like to be on-lined.
##########
File path: modules/core/src/test/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoveryPendingMessageDeliveryTest.java
##########
@@ -251,10 +251,10 @@ private void sendDummyCustomMessage(TcpDiscoverySpi disco, IgniteUuid id) {
*/
private class DyingDiscoverySpi extends TcpDiscoverySpi {
/** {@inheritDoc} */
- @Override protected void writeToSocket(Socket sock, TcpDiscoveryAbstractMessage msg, byte[] data,
- long timeout) throws IOException {
+ @Override protected void writeToSocket(Socket sock, byte[] data,
+ long timeout) throws IOException {
Review comment:
Looks like to be on-lined.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org