You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2017/12/09 02:38:28 UTC
[kudu-CR] [quorum util] rename 3-4-3-related utility functions
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8806
Change subject: [quorum_util] rename 3-4-3-related utility functions
......................................................................
[quorum_util] rename 3-4-3-related utility functions
Renaming a couple of 3-4-3-related utility functions to make the naming
more symmetric:
* IsUnderReplicated() --> ShouldAddReplica()
* CanEvictReplica() --> ShouldEvictReplica()
This changelist does not contain any functional modifications.
Change-Id: I2f6d27588f6ccfb5c889471107b2df969e239bea
---
M src/kudu/consensus/quorum_util-test.cc
M src/kudu/consensus/quorum_util.cc
M src/kudu/consensus/quorum_util.h
M src/kudu/master/catalog_manager.cc
4 files changed, 198 insertions(+), 196 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/06/8806/1
--
To view, visit http://gerrit.cloudera.org:8080/8806
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2f6d27588f6ccfb5c889471107b2df969e239bea
Gerrit-Change-Number: 8806
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [quorum util] rename 3-4-3-related utility functions
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8806 )
Change subject: [quorum_util] rename 3-4-3-related utility functions
......................................................................
[quorum_util] rename 3-4-3-related utility functions
Renaming a couple of 3-4-3-related utility functions to make the naming
more symmetric:
* IsUnderReplicated() --> ShouldAddReplica()
* CanEvictReplica() --> ShouldEvictReplica()
This changelist does not contain any functional modifications.
Change-Id: I2f6d27588f6ccfb5c889471107b2df969e239bea
Reviewed-on: http://gerrit.cloudera.org:8080/8806
Tested-by: Kudu Jenkins
Reviewed-by: Mike Percy <mp...@apache.org>
---
M src/kudu/consensus/quorum_util-test.cc
M src/kudu/consensus/quorum_util.cc
M src/kudu/consensus/quorum_util.h
M src/kudu/master/catalog_manager.cc
4 files changed, 198 insertions(+), 196 deletions(-)
Approvals:
Kudu Jenkins: Verified
Mike Percy: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/8806
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I2f6d27588f6ccfb5c889471107b2df969e239bea
Gerrit-Change-Number: 8806
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] [quorum util] rename 3-4-3-related utility functions
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8806 )
Change subject: [quorum_util] rename 3-4-3-related utility functions
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/8806
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f6d27588f6ccfb5c889471107b2df969e239bea
Gerrit-Change-Number: 8806
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Tue, 12 Dec 2017 21:14:18 +0000
Gerrit-HasComments: No