You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by "Technoboy- (via GitHub)" <gi...@apache.org> on 2023/11/17 00:24:35 UTC

Re: [PR] [fix][test] Detects whether an empty object is returned, prevent NPE exception [pulsar]

Technoboy- commented on code in PR #21585:
URL: https://github.com/apache/pulsar/pull/21585#discussion_r1396528573


##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/PartitionedProducerImpl.java:
##########
@@ -372,7 +372,7 @@ String getHandlerName() {
     }
 
     // This listener is triggered when topics partitions are updated.
-    private class TopicsPartitionChangedListener implements PartitionsChangedListener {
+    public class TopicsPartitionChangedListener implements PartitionsChangedListener {

Review Comment:
   Better not change this to `public`.
   Using PartitionedProducerImpl#`getPartitionsAutoUpdateFuture` could help the test



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org