You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/09/16 02:48:36 UTC
[GitHub] [dubbo-go] zhaoyunxing92 commented on a change in pull request #1459: Fix: metrics、k8s、pprof
zhaoyunxing92 commented on a change in pull request #1459:
URL: https://github.com/apache/dubbo-go/pull/1459#discussion_r709709019
##########
File path: metrics/prometheus/reporter.go
##########
@@ -57,14 +62,16 @@ const (
)
var (
- labelNames = []string{serviceKey, groupKey, versionKey, methodKey, timeoutKey}
- namespace = config.GetApplicationConfig().Name
- reporterInstance *PrometheusReporter
- reporterInitOnce sync.Once
+ labelNames = []string{serviceKey, groupKey, versionKey, methodKey, timeoutKey}
+ namespace = config.GetApplicationConfig().Name
Review comment:
我建议namespace单独搞一个吧不要用application的name，prometheus对命名规范有要求的，除非你让用户吧application的name改成下划线链接
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org