You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by xiaosuo <gi...@git.apache.org> on 2017/03/10 05:35:35 UTC
[GitHub] thrift pull request #1210: Fix fd leak when failing to dispatch new connecti...
GitHub user xiaosuo opened a pull request:
https://github.com/apache/thrift/pull/1210
Fix fd leak when failing to dispatch new connections
When failing to dispatch new connections to other IO threads other
than the number 0, we returned these connections for reuse without
closing them, so the corresponding fds were leaked forever.
We should close these connections instead.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xiaosuo/thrift fd_leak
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1210.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1210
----
commit 7e067d0464e1a4ee8c6c5d1899a7aa3e6ecfdce1
Author: Changli Gao <xi...@gmail.com>
Date: 2017-03-10T05:15:37Z
Fix fd leak when failing to dispatch new connections
When failing to dispatch new connections to other IO threads other
than the number 0, we returned these connections for reuse without
closing them, so the corresponding fds were leaked forever.
We should close these connections instead.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1210: Fix fd leak when failing to dispatch new connections
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1210
I opened THRIFT-4129 for this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request #1210: Fix fd leak when failing to dispatch new connecti...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/1210
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---