You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by danobi <gi...@git.apache.org> on 2015/07/08 19:51:46 UTC
[GitHub] trafficserver pull request: TS-3435 Make Log.cc:PERIODIC_TASKS_INT...
GitHub user danobi opened a pull request:
https://github.com/apache/trafficserver/pull/243
TS-3435 Make Log.cc:PERIODIC_TASKS_INTERVAL configurable
Allow interval between periodic tasks in Log.cc to be configured
via records.config. This allows for finer granularity when managing
log based periodic tasks.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/danobi/trafficserver TS-3435
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/243.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #243
----
commit a8788561c1c0c4530b2ec39b75e3e61e827b7123
Author: Daniel Xu <da...@yahoo-inc.com>
Date: 2015-07-07T13:13:31Z
TS-3435 Make Log.cc:PERIODIC_TASKS_INTERVAL configurable
Allow interval between periodic tasks in Log.cc to be configured
via records.config. This allows for a finer granularity when
managing log based periodic tasks.
commit dfd665bfb5fa1e130c772b8f62efe0316ed13e1b
Author: Daniel Xu <da...@yahoo-inc.com>
Date: 2015-07-07T13:18:23Z
Removed trailing whitespace and ran clang-format
commit 27dfa31e1523c93f4dff94f2bc76ca020b0c4906
Author: Daniel Xu <da...@yahoo-inc.com>
Date: 2015-07-07T13:35:57Z
Add regex expression to validate new interval
commit c205bdf341f2a08aeccad4ca6b9043ecefb91da0
Author: Daniel Xu <da...@yahoo-inc.com>
Date: 2015-07-08T17:40:25Z
Use uint32_t instead of int to prevent negative overflows
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-3435 Make Log.cc:PERIODIC_TASKS_INT...
Posted by danobi <gi...@git.apache.org>.
Github user danobi commented on the pull request:
https://github.com/apache/trafficserver/pull/243#issuecomment-120055508
I didn't have any specific reason. It seemed like it wouldn't cause any problems, so I just added it in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-3435 Make Log.cc:PERIODIC_TASKS_INT...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/trafficserver/pull/243
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-3435 Make Log.cc:PERIODIC_TASKS_INT...
Posted by shinrich <gi...@git.apache.org>.
Github user shinrich commented on the pull request:
https://github.com/apache/trafficserver/pull/243#issuecomment-119959897
Looks good. My only question is why you bothered to make this a dynamic config. It seems like requiring a restart would not be bad.
I don't think there are any bad race conditions here. And I suppose of the operator is honing in on a desirable collection interval the dynamic restart might be useful.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---