You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/04/18 03:04:53 UTC
[GitHub] [shardingsphere] strongduanmu commented on a change in pull request
#5223: provide SPI spring namespace configuration for sharding algorithms
strongduanmu commented on a change in pull request #5223: provide SPI spring namespace configuration for sharding algorithms
URL: https://github.com/apache/shardingsphere/pull/5223#discussion_r410579130
##########
File path: sharding-spring/sharding-jdbc-orchestration-spring/sharding-jdbc-orchestration-spring-namespace/src/test/resources/META-INF/rdb/namespace/shardingMasterSlaveNamespace.xml
##########
@@ -32,12 +32,12 @@
">
<import resource="../datasource/masterSlaveDataSource.xml" />
-
- <bean id="standardModuloDatabaseShardingAlgorithm" class="org.apache.shardingsphere.shardingjdbc.orchestration.spring.algorithm.StandardModuloDatabaseShardingAlgorithm" />
- <bean id="standardModuloTableShardingAlgorithm" class="org.apache.shardingsphere.shardingjdbc.orchestration.spring.algorithm.StandardModuloTableShardingAlgorithm" />
- <bean id="defaultComplexKeysShardingAlgorithm" class="org.apache.shardingsphere.shardingjdbc.orchestration.spring.algorithm.DefaultComplexKeysShardingAlgorithm" />
- <bean id="defaultHintShardingAlgorithm" class="org.apache.shardingsphere.shardingjdbc.orchestration.spring.algorithm.DefaultHintShardingAlgorithm" />
-
+
+ <spi:sharding-algorithm id="standardModuloDatabaseShardingAlgorithm" type="STANDARD_TEST_DB"/>
+ <spi:sharding-algorithm id="standardModuloTableShardingAlgorithm" type="STANDARD_TEST_TBL"/>
+ <spi:sharding-algorithm id="defaultComplexKeysShardingAlgorithm" type="complex"/>
Review comment:
> `complex` is not a proper type name, so could rename it in `defaultComplexKeysShardingAlgorithm ` as `COMPLEX_TEST`.
@tristaZero Okay, I will modify it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services