You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/18 10:50:26 UTC

[GitHub] [flink] zhuzhurk opened a new pull request #11121: [FLINK-16139][runtime] Reset colocation constraints when restarting tasks in DefaultScheduler

zhuzhurk opened a new pull request #11121: [FLINK-16139][runtime] Reset colocation constraints when restarting tasks in DefaultScheduler
URL: https://github.com/apache/flink/pull/11121
 
 
   ## What is the purpose of the change
   
   The colocation constraints are not reset on task recovery, which may lead to task recovery failures when allocating slots.
   We should reset the colocation constraints before resetting vertices, just like what we do in the legacy scheduler.
   
   ## Brief change log
   
     - *Reset colocation constraints when restarting tasks in DefaultScheduler#resetForNewExecutions(...)*
   
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
     - *Added a unit test*
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (**yes** / no / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11121: [FLINK-16139][runtime] Reset colocation constraints when restarting tasks in DefaultScheduler

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11121: [FLINK-16139][runtime] Reset colocation constraints when restarting tasks in DefaultScheduler
URL: https://github.com/apache/flink/pull/11121#issuecomment-587415207
 
 
   <!--
   Meta data
   Hash:1f237d6573e7dfe601a875732d5865ddb4e07d1c Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/149430700 TriggerType:PUSH TriggerID:1f237d6573e7dfe601a875732d5865ddb4e07d1c
   -->
   ## CI report:
   
   * 1f237d6573e7dfe601a875732d5865ddb4e07d1c Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/149430700) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zhuzhurk commented on issue #11121: [FLINK-16139][runtime] Reset colocation constraints when restarting tasks in DefaultScheduler

Posted by GitBox <gi...@apache.org>.
zhuzhurk commented on issue #11121: [FLINK-16139][runtime] Reset colocation constraints when restarting tasks in DefaultScheduler
URL: https://github.com/apache/flink/pull/11121#issuecomment-589450668
 
 
   Thanks @tillrohrmann for reviewing!
   Merging.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11121: [FLINK-16139][runtime] Reset colocation constraints when restarting tasks in DefaultScheduler

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11121: [FLINK-16139][runtime] Reset colocation constraints when restarting tasks in DefaultScheduler
URL: https://github.com/apache/flink/pull/11121#issuecomment-587415207
 
 
   <!--
   Meta data
   Hash:1f237d6573e7dfe601a875732d5865ddb4e07d1c Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/149430700 TriggerType:PUSH TriggerID:1f237d6573e7dfe601a875732d5865ddb4e07d1c
   Hash:1f237d6573e7dfe601a875732d5865ddb4e07d1c Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5274 TriggerType:PUSH TriggerID:1f237d6573e7dfe601a875732d5865ddb4e07d1c
   Hash:a2bd416f884ac83d22400a078066abd33edbe414 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:a2bd416f884ac83d22400a078066abd33edbe414
   -->
   ## CI report:
   
   * 1f237d6573e7dfe601a875732d5865ddb4e07d1c Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/149430700) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5274) 
   * a2bd416f884ac83d22400a078066abd33edbe414 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11121: [FLINK-16139][runtime] Reset colocation constraints when restarting tasks in DefaultScheduler

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11121: [FLINK-16139][runtime] Reset colocation constraints when restarting tasks in DefaultScheduler
URL: https://github.com/apache/flink/pull/11121#issuecomment-587415207
 
 
   <!--
   Meta data
   Hash:1f237d6573e7dfe601a875732d5865ddb4e07d1c Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/149430700 TriggerType:PUSH TriggerID:1f237d6573e7dfe601a875732d5865ddb4e07d1c
   Hash:1f237d6573e7dfe601a875732d5865ddb4e07d1c Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5274 TriggerType:PUSH TriggerID:1f237d6573e7dfe601a875732d5865ddb4e07d1c
   Hash:a2bd416f884ac83d22400a078066abd33edbe414 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/149926567 TriggerType:PUSH TriggerID:a2bd416f884ac83d22400a078066abd33edbe414
   -->
   ## CI report:
   
   * 1f237d6573e7dfe601a875732d5865ddb4e07d1c Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/149430700) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5274) 
   * a2bd416f884ac83d22400a078066abd33edbe414 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/149926567) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zhuzhurk commented on issue #11121: [FLINK-16139][runtime] Reset colocation constraints when restarting tasks in DefaultScheduler

Posted by GitBox <gi...@apache.org>.
zhuzhurk commented on issue #11121: [FLINK-16139][runtime] Reset colocation constraints when restarting tasks in DefaultScheduler
URL: https://github.com/apache/flink/pull/11121#issuecomment-587400749
 
 
   @tillrohrmann would you take a look at this fix? @GJL is on vacation.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #11121: [FLINK-16139][runtime] Reset colocation constraints when restarting tasks in DefaultScheduler

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11121: [FLINK-16139][runtime] Reset colocation constraints when restarting tasks in DefaultScheduler
URL: https://github.com/apache/flink/pull/11121#issuecomment-587401198
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 1f237d6573e7dfe601a875732d5865ddb4e07d1c (Tue Feb 18 10:53:43 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11121: [FLINK-16139][runtime] Reset colocation constraints when restarting tasks in DefaultScheduler

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11121: [FLINK-16139][runtime] Reset colocation constraints when restarting tasks in DefaultScheduler
URL: https://github.com/apache/flink/pull/11121#issuecomment-587415207
 
 
   <!--
   Meta data
   Hash:1f237d6573e7dfe601a875732d5865ddb4e07d1c Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/149430700 TriggerType:PUSH TriggerID:1f237d6573e7dfe601a875732d5865ddb4e07d1c
   Hash:1f237d6573e7dfe601a875732d5865ddb4e07d1c Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5274 TriggerType:PUSH TriggerID:1f237d6573e7dfe601a875732d5865ddb4e07d1c
   -->
   ## CI report:
   
   * 1f237d6573e7dfe601a875732d5865ddb4e07d1c Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/149430700) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5274) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #11121: [FLINK-16139][runtime] Reset colocation constraints when restarting tasks in DefaultScheduler

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11121: [FLINK-16139][runtime] Reset colocation constraints when restarting tasks in DefaultScheduler
URL: https://github.com/apache/flink/pull/11121#issuecomment-587415207
 
 
   <!--
   Meta data
   Hash:1f237d6573e7dfe601a875732d5865ddb4e07d1c Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:1f237d6573e7dfe601a875732d5865ddb4e07d1c
   -->
   ## CI report:
   
   * 1f237d6573e7dfe601a875732d5865ddb4e07d1c UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zhuzhurk merged pull request #11121: [FLINK-16139][runtime] Reset colocation constraints when restarting tasks in DefaultScheduler

Posted by GitBox <gi...@apache.org>.
zhuzhurk merged pull request #11121: [FLINK-16139][runtime] Reset colocation constraints when restarting tasks in DefaultScheduler
URL: https://github.com/apache/flink/pull/11121
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11121: [FLINK-16139][runtime] Reset colocation constraints when restarting tasks in DefaultScheduler

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11121: [FLINK-16139][runtime] Reset colocation constraints when restarting tasks in DefaultScheduler
URL: https://github.com/apache/flink/pull/11121#issuecomment-587415207
 
 
   <!--
   Meta data
   Hash:1f237d6573e7dfe601a875732d5865ddb4e07d1c Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/149430700 TriggerType:PUSH TriggerID:1f237d6573e7dfe601a875732d5865ddb4e07d1c
   Hash:1f237d6573e7dfe601a875732d5865ddb4e07d1c Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5274 TriggerType:PUSH TriggerID:1f237d6573e7dfe601a875732d5865ddb4e07d1c
   Hash:a2bd416f884ac83d22400a078066abd33edbe414 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/149926567 TriggerType:PUSH TriggerID:a2bd416f884ac83d22400a078066abd33edbe414
   -->
   ## CI report:
   
   * 1f237d6573e7dfe601a875732d5865ddb4e07d1c Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/149430700) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5274) 
   * a2bd416f884ac83d22400a078066abd33edbe414 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/149926567) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services