You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/09/14 21:23:10 UTC
[GitHub] [tvm] Lunderberg opened a new pull request, #12784: [Arith][Refactor] Return Optional from TryConstFold
Lunderberg opened a new pull request, #12784:
URL: https://github.com/apache/tvm/pull/12784
Prior to this commit, the templated `TryConstFold` utility returned an undefined `PrimExpr` to represent a failure to perform constant folding. This commit makes this explicit by returning `Optional<PrimExpr>` instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] wrongtest-intellif merged pull request #12784: [Arith][Refactor] Return Optional from TryConstFold
Posted by GitBox <gi...@apache.org>.
wrongtest-intellif merged PR #12784:
URL: https://github.com/apache/tvm/pull/12784
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Lunderberg commented on pull request #12784: [Arith][Refactor] Return Optional from TryConstFold
Posted by GitBox <gi...@apache.org>.
Lunderberg commented on PR #12784:
URL: https://github.com/apache/tvm/pull/12784#issuecomment-1247316761
From a brief look at the commit history, `TryConstFold` was introduced in https://github.com/apache/tvm/pull/2719, significantly predating the introduction of `Optional` in https://github.com/apache/tvm/pull/5314.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org