You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/03/15 10:25:20 UTC
[GitHub] [hudi] codope opened a new pull request #5045: [HUDI-3633] Allow non-string values to be set in TypedProperties
codope opened a new pull request #5045:
URL: https://github.com/apache/hudi/pull/5045
## What is the purpose of the pull request
`TypedProperties` invokes `Properties#stringPropertynames()` which expects that key and values should be strings. It causes keys with non-string values to be not found. See #5026 . This PR fixes that behavior.
## Brief change log
*(for example:)*
- *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #5045: [HUDI-3633] Allow non-string values to be set in TypedProperties
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #5045:
URL: https://github.com/apache/hudi/pull/5045#issuecomment-1068221118
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ec5bb04aa1f2671485087d9f14568661efc4aa3e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6962",
"triggerID" : "ec5bb04aa1f2671485087d9f14568661efc4aa3e",
"triggerType" : "PUSH"
}, {
"hash" : "1e63407f7d8ec725c78b11a6e2dfae08816d36c7",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6967",
"triggerID" : "1e63407f7d8ec725c78b11a6e2dfae08816d36c7",
"triggerType" : "PUSH"
}, {
"hash" : "1e63407f7d8ec725c78b11a6e2dfae08816d36c7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6969",
"triggerID" : "1068219502",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 1e63407f7d8ec725c78b11a6e2dfae08816d36c7 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6967) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6969)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5045: [HUDI-3633] Allow non-string values to be set in TypedProperties
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #5045:
URL: https://github.com/apache/hudi/pull/5045#issuecomment-1068084206
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ec5bb04aa1f2671485087d9f14568661efc4aa3e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6962",
"triggerID" : "ec5bb04aa1f2671485087d9f14568661efc4aa3e",
"triggerType" : "PUSH"
}, {
"hash" : "1e63407f7d8ec725c78b11a6e2dfae08816d36c7",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6967",
"triggerID" : "1e63407f7d8ec725c78b11a6e2dfae08816d36c7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1e63407f7d8ec725c78b11a6e2dfae08816d36c7 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6967)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codope commented on pull request #5045: [HUDI-3633] Allow non-string values to be set in TypedProperties
Posted by GitBox <gi...@apache.org>.
codope commented on pull request #5045:
URL: https://github.com/apache/hudi/pull/5045#issuecomment-1067929525
>
Still the `TypedProperties` constructor takes a `Properties` argument and calling `defaults.getProperty` won't have the desired effect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5045: [HUDI-3633] Allow non-string values to be set in TypedProperties
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #5045:
URL: https://github.com/apache/hudi/pull/5045#issuecomment-1068221118
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ec5bb04aa1f2671485087d9f14568661efc4aa3e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6962",
"triggerID" : "ec5bb04aa1f2671485087d9f14568661efc4aa3e",
"triggerType" : "PUSH"
}, {
"hash" : "1e63407f7d8ec725c78b11a6e2dfae08816d36c7",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6967",
"triggerID" : "1e63407f7d8ec725c78b11a6e2dfae08816d36c7",
"triggerType" : "PUSH"
}, {
"hash" : "1e63407f7d8ec725c78b11a6e2dfae08816d36c7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6969",
"triggerID" : "1068219502",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 1e63407f7d8ec725c78b11a6e2dfae08816d36c7 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6967) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6969)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] wangxianghu commented on pull request #5045: [HUDI-3633] Allow non-string values to be set in TypedProperties
Posted by GitBox <gi...@apache.org>.
wangxianghu commented on pull request #5045:
URL: https://github.com/apache/hudi/pull/5045#issuecomment-1067854086
hi @codope This patch solved issue https://github.com/apache/hudi/issues/5026
but if the user use
```
typedProperties.put("key", 123);
```
the kv still lost
may be we should override java.util.Properties#getProperty(java.lang.String) to ingnore the val type
```
public String getProperty(String key) {
Object oval = super.get(key);
String sval = (oval instanceof String) ? (String)oval : null;
return ((sval == null) && (defaults != null)) ? defaults.getProperty(key) : sval;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #5045: [HUDI-3633] Allow non-string values to be set in TypedProperties
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #5045:
URL: https://github.com/apache/hudi/pull/5045#issuecomment-1067817045
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ec5bb04aa1f2671485087d9f14568661efc4aa3e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6962",
"triggerID" : "ec5bb04aa1f2671485087d9f14568661efc4aa3e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ec5bb04aa1f2671485087d9f14568661efc4aa3e Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6962)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5045: [HUDI-3633] Allow non-string values to be set in TypedProperties
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #5045:
URL: https://github.com/apache/hudi/pull/5045#issuecomment-1067817045
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ec5bb04aa1f2671485087d9f14568661efc4aa3e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6962",
"triggerID" : "ec5bb04aa1f2671485087d9f14568661efc4aa3e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ec5bb04aa1f2671485087d9f14568661efc4aa3e Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6962)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] wangxianghu edited a comment on pull request #5045: [HUDI-3633] Allow non-string values to be set in TypedProperties
Posted by GitBox <gi...@apache.org>.
wangxianghu edited a comment on pull request #5045:
URL: https://github.com/apache/hudi/pull/5045#issuecomment-1067854086
hi @codope This patch solved issue https://github.com/apache/hudi/issues/5026
but if the user use
```
typedProperties.put("key", 123);
```
the kv still lost
may be we should override java.util.Properties#getProperty(java.lang.String) to ingnore the val type
the getProperty method in java.util.Properties:
```
public String getProperty(String key) {
Object oval = super.get(key);
String sval = (oval instanceof String) ? (String)oval : null;
return ((sval == null) && (defaults != null)) ? defaults.getProperty(key) : sval;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] wangxianghu merged pull request #5045: [HUDI-3633] Allow non-string values to be set in TypedProperties
Posted by GitBox <gi...@apache.org>.
wangxianghu merged pull request #5045:
URL: https://github.com/apache/hudi/pull/5045
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5045: [HUDI-3633] Allow non-string values to be set in TypedProperties
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #5045:
URL: https://github.com/apache/hudi/pull/5045#issuecomment-1068001528
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ec5bb04aa1f2671485087d9f14568661efc4aa3e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6962",
"triggerID" : "ec5bb04aa1f2671485087d9f14568661efc4aa3e",
"triggerType" : "PUSH"
}, {
"hash" : "1e63407f7d8ec725c78b11a6e2dfae08816d36c7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6967",
"triggerID" : "1e63407f7d8ec725c78b11a6e2dfae08816d36c7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ec5bb04aa1f2671485087d9f14568661efc4aa3e Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6962)
* 1e63407f7d8ec725c78b11a6e2dfae08816d36c7 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6967)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5045: [HUDI-3633] Allow non-string values to be set in TypedProperties
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #5045:
URL: https://github.com/apache/hudi/pull/5045#issuecomment-1068303931
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ec5bb04aa1f2671485087d9f14568661efc4aa3e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6962",
"triggerID" : "ec5bb04aa1f2671485087d9f14568661efc4aa3e",
"triggerType" : "PUSH"
}, {
"hash" : "1e63407f7d8ec725c78b11a6e2dfae08816d36c7",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6967",
"triggerID" : "1e63407f7d8ec725c78b11a6e2dfae08816d36c7",
"triggerType" : "PUSH"
}, {
"hash" : "1e63407f7d8ec725c78b11a6e2dfae08816d36c7",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6969",
"triggerID" : "1068219502",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 1e63407f7d8ec725c78b11a6e2dfae08816d36c7 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6967) Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6969)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codope commented on pull request #5045: [HUDI-3633] Allow non-string values to be set in TypedProperties
Posted by GitBox <gi...@apache.org>.
codope commented on pull request #5045:
URL: https://github.com/apache/hudi/pull/5045#issuecomment-1067895022
> may be we should override java.util.Properties#getProperty(java.lang.String) to ignore the string type check
the getProperty method in java.util.Properties
We could do that. I wonder why was this `instanceof String` check added?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5045: [HUDI-3633] Allow non-string values to be set in TypedProperties
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #5045:
URL: https://github.com/apache/hudi/pull/5045#issuecomment-1067813856
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ec5bb04aa1f2671485087d9f14568661efc4aa3e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ec5bb04aa1f2671485087d9f14568661efc4aa3e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ec5bb04aa1f2671485087d9f14568661efc4aa3e UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #5045: [HUDI-3633] Allow non-string values to be set in TypedProperties
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #5045:
URL: https://github.com/apache/hudi/pull/5045#issuecomment-1067887691
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ec5bb04aa1f2671485087d9f14568661efc4aa3e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6962",
"triggerID" : "ec5bb04aa1f2671485087d9f14568661efc4aa3e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ec5bb04aa1f2671485087d9f14568661efc4aa3e Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6962)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #5045: [HUDI-3633] Allow non-string values to be set in TypedProperties
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #5045:
URL: https://github.com/apache/hudi/pull/5045#issuecomment-1067998516
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ec5bb04aa1f2671485087d9f14568661efc4aa3e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6962",
"triggerID" : "ec5bb04aa1f2671485087d9f14568661efc4aa3e",
"triggerType" : "PUSH"
}, {
"hash" : "1e63407f7d8ec725c78b11a6e2dfae08816d36c7",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1e63407f7d8ec725c78b11a6e2dfae08816d36c7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ec5bb04aa1f2671485087d9f14568661efc4aa3e Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6962)
* 1e63407f7d8ec725c78b11a6e2dfae08816d36c7 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5045: [HUDI-3633] Allow non-string values to be set in TypedProperties
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #5045:
URL: https://github.com/apache/hudi/pull/5045#issuecomment-1067887691
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ec5bb04aa1f2671485087d9f14568661efc4aa3e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6962",
"triggerID" : "ec5bb04aa1f2671485087d9f14568661efc4aa3e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ec5bb04aa1f2671485087d9f14568661efc4aa3e Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6962)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] wangxianghu commented on pull request #5045: [HUDI-3633] Allow non-string values to be set in TypedProperties
Posted by GitBox <gi...@apache.org>.
wangxianghu commented on pull request #5045:
URL: https://github.com/apache/hudi/pull/5045#issuecomment-1068219502
@hudi-bot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] wangxianghu commented on pull request #5045: [HUDI-3633] Allow non-string values to be set in TypedProperties
Posted by GitBox <gi...@apache.org>.
wangxianghu commented on pull request #5045:
URL: https://github.com/apache/hudi/pull/5045#issuecomment-1067916034
> > may be we should override java.util.Properties#getProperty(java.lang.String) to ignore the string type check
> > the getProperty method in java.util.Properties
>
> We could do that. I wonder why was this `instanceof String` check added?
The return type is String, use `instanceof String` check may avoid class cast exception
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5045: [HUDI-3633] Allow non-string values to be set in TypedProperties
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #5045:
URL: https://github.com/apache/hudi/pull/5045#issuecomment-1067998516
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ec5bb04aa1f2671485087d9f14568661efc4aa3e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6962",
"triggerID" : "ec5bb04aa1f2671485087d9f14568661efc4aa3e",
"triggerType" : "PUSH"
}, {
"hash" : "1e63407f7d8ec725c78b11a6e2dfae08816d36c7",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1e63407f7d8ec725c78b11a6e2dfae08816d36c7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ec5bb04aa1f2671485087d9f14568661efc4aa3e Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6962)
* 1e63407f7d8ec725c78b11a6e2dfae08816d36c7 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #5045: [HUDI-3633] Allow non-string values to be set in TypedProperties
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #5045:
URL: https://github.com/apache/hudi/pull/5045#issuecomment-1068001528
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ec5bb04aa1f2671485087d9f14568661efc4aa3e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6962",
"triggerID" : "ec5bb04aa1f2671485087d9f14568661efc4aa3e",
"triggerType" : "PUSH"
}, {
"hash" : "1e63407f7d8ec725c78b11a6e2dfae08816d36c7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6967",
"triggerID" : "1e63407f7d8ec725c78b11a6e2dfae08816d36c7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ec5bb04aa1f2671485087d9f14568661efc4aa3e Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6962)
* 1e63407f7d8ec725c78b11a6e2dfae08816d36c7 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6967)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #5045: [HUDI-3633] Allow non-string values to be set in TypedProperties
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #5045:
URL: https://github.com/apache/hudi/pull/5045#issuecomment-1067813856
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ec5bb04aa1f2671485087d9f14568661efc4aa3e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ec5bb04aa1f2671485087d9f14568661efc4aa3e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ec5bb04aa1f2671485087d9f14568661efc4aa3e UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #5045: [HUDI-3633] Allow non-string values to be set in TypedProperties
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #5045:
URL: https://github.com/apache/hudi/pull/5045#issuecomment-1068084206
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ec5bb04aa1f2671485087d9f14568661efc4aa3e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6962",
"triggerID" : "ec5bb04aa1f2671485087d9f14568661efc4aa3e",
"triggerType" : "PUSH"
}, {
"hash" : "1e63407f7d8ec725c78b11a6e2dfae08816d36c7",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6967",
"triggerID" : "1e63407f7d8ec725c78b11a6e2dfae08816d36c7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1e63407f7d8ec725c78b11a6e2dfae08816d36c7 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6967)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] wangxianghu edited a comment on pull request #5045: [HUDI-3633] Allow non-string values to be set in TypedProperties
Posted by GitBox <gi...@apache.org>.
wangxianghu edited a comment on pull request #5045:
URL: https://github.com/apache/hudi/pull/5045#issuecomment-1067854086
hi @codope This patch solved issue https://github.com/apache/hudi/issues/5026
but if the user use
```
typedProperties.put("key", 123);
```
the kv still lost
may be we should override java.util.Properties#getProperty(java.lang.String) to ignore the string type check
the getProperty method in java.util.Properties:
```
public String getProperty(String key) {
Object oval = super.get(key);
String sval = (oval instanceof String) ? (String)oval : null;
return ((sval == null) && (defaults != null)) ? defaults.getProperty(key) : sval;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] wangxianghu removed a comment on pull request #5045: [HUDI-3633] Allow non-string values to be set in TypedProperties
Posted by GitBox <gi...@apache.org>.
wangxianghu removed a comment on pull request #5045:
URL: https://github.com/apache/hudi/pull/5045#issuecomment-1067914420
> > may be we should override java.util.Properties#getProperty(java.lang.String) to ignore the string type check
> > the getProperty method in java.util.Properties
>
> We could do that. I wonder why was this `instanceof String` check added?
The return type of `getProperty()` is String, `instanceof String` may avoid class cast exception
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] wangxianghu commented on pull request #5045: [HUDI-3633] Allow non-string values to be set in TypedProperties
Posted by GitBox <gi...@apache.org>.
wangxianghu commented on pull request #5045:
URL: https://github.com/apache/hudi/pull/5045#issuecomment-1067914420
> > may be we should override java.util.Properties#getProperty(java.lang.String) to ignore the string type check
> > the getProperty method in java.util.Properties
>
> We could do that. I wonder why was this `instanceof String` check added?
The return type of `getProperty()` is String, `instanceof String` may avoid class cast exception
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org