You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by rileyli <gi...@git.apache.org> on 2018/07/24 08:28:33 UTC

[GitHub] flink pull request #6401: [hotfix]fix typo for variable name dynamicProperti...

GitHub user rileyli opened a pull request:

    https://github.com/apache/flink/pull/6401

    [hotfix]fix typo for variable name dynamicProperties in FlinkYarnSessionCli.java

    ### What is the purpose of the change
    fix typo for variable name dynamicProperties in FlinkYarnSessionCli.java

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rileyli/flink master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/6401.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #6401
    
----
commit 843d7df52ceef6ba54f9d95f2843282b9c842fd2
Author: Riley Li <ru...@...>
Date:   2018-07-24T08:25:11Z

    fix typo for variable name dynamicProperties in FlinkYarnSessionCli.java

----


---

[GitHub] flink pull request #6401: [hotfix]fix typo for variable name dynamicProperti...

Posted by rileyli <gi...@git.apache.org>.

Github user rileyli closed the pull request at:

    https://github.com/apache/flink/pull/6401


---

[GitHub] flink issue #6401: [hotfix]fix typo for variable name dynamicProperties in F...

Posted by tillrohrmann <gi...@git.apache.org>.

Github user tillrohrmann commented on the issue:

    https://github.com/apache/flink/pull/6401
  
    Thanks for your contribution @rileyli. Even though this change seems rather trivial I would like to discourage these kind of contributions. The problem is that it does not add much additional value at the cost of introducing subtle bugs (e.g. variable name clashes). Therefore, I would like to ask you to close this PR.


---

[GitHub] flink issue #6401: [hotfix]fix typo for variable name dynamicProperties in F...

Posted by yanghua <gi...@git.apache.org>.

Github user yanghua commented on the issue:

    https://github.com/apache/flink/pull/6401
  
    hi @rileyli Thanks for your contribution, but I think just refactor the naming style is not very necessary and it is not "typo". cc @zentol @tillrohrmann 


---