You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by markobean <gi...@git.apache.org> on 2018/10/09 15:13:54 UTC

[GitHub] nifi pull request #3053: NIFI-5660: JMSPublisher should not set header prope...

GitHub user markobean opened a pull request:

    https://github.com/apache/nifi/pull/3053

    NIFI-5660: JMSPublisher should not set header properties directly in …

    …the message
    
    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
    
    Integration tests validated expected behavior.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/markobean/nifi NIFI-5660

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/3053.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3053
    
----
commit b6e5ca9d44e54fd3fc2cdc40b4a21a1b6783a452
Author: Mark Bean <ma...@...>
Date:   2018-10-05T14:08:28Z

    NIFI-5660: JMSPublisher should not set header properties directly in the message

----


---

[GitHub] nifi pull request #3053: NIFI-5660: JMSPublisher should not set header prope...

Posted by markobean <gi...@git.apache.org>.
Github user markobean commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/3053#discussion_r223751456
  
    --- Diff: nifi-nar-bundles/nifi-jms-bundle/nifi-jms-processors/src/main/java/org/apache/nifi/jms/processors/JMSPublisher.java ---
    @@ -89,11 +89,14 @@ void setMessageHeaderAndProperties(final Message message, final Map<String, Stri
                 for (Entry<String, String> entry : flowFileAttributesToSend.entrySet()) {
                     try {
                         if (entry.getKey().equals(JmsHeaders.DELIVERY_MODE)) {
    -                        message.setJMSDeliveryMode(Integer.parseInt(entry.getValue()));
    +                        this.jmsTemplate.setExplicitQosEnabled(true);
    --- End diff --
    
    No, it should not. The only changes is setting these values through the JmsTemplate vice the Message itself due to stated limitation of the API. The net effect is the same.


---

[GitHub] nifi pull request #3053: NIFI-5660: JMSPublisher should not set header prope...

Posted by joewitt <gi...@git.apache.org>.
Github user joewitt commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/3053#discussion_r223748531
  
    --- Diff: nifi-nar-bundles/nifi-jms-bundle/nifi-jms-processors/src/main/java/org/apache/nifi/jms/processors/JMSPublisher.java ---
    @@ -89,11 +89,14 @@ void setMessageHeaderAndProperties(final Message message, final Map<String, Stri
                 for (Entry<String, String> entry : flowFileAttributesToSend.entrySet()) {
                     try {
                         if (entry.getKey().equals(JmsHeaders.DELIVERY_MODE)) {
    -                        message.setJMSDeliveryMode(Integer.parseInt(entry.getValue()));
    +                        this.jmsTemplate.setExplicitQosEnabled(true);
    --- End diff --
    
    are setting these values explicitly and without any configurability going to limit usage of these processors for certain JMS brokers? 


---