You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@orc.apache.org by "oushu1zhouzhanghua1 (via GitHub)" <gi...@apache.org> on 2023/06/30 02:18:07 UTC

[GitHub] [orc] oushu1zhouzhanghua1 opened a new issue, #1556: SIGSEGV When read statistics of an all null boolean stripe.

oushu1zhouzhanghua1 opened a new issue, #1556:
URL: https://github.com/apache/orc/issues/1556

   orc-statistic is a tool using Apache Orc Reader to get statistics of orc file, 
   and I got a SIGSEGV when processing a stripe with an all null boolean columns.
   
   When BooleanColumnStatisticsImpl::toProtoBuf, mutable_bucketstatistics() is called.
   https://github.com/apache/orc/blob/0aba9875be4396c40adedae5a257e622d43b64eb/c%2B%2B/src/Statistics.hh#L463
   
   The Protocol Buffers Docs[https://protobuf.dev/reference/cpp/cpp-generated/] saying:
   ```
   Bar* mutable_foo(): Returns a pointer to the mutable Bar object that stores the field’s value. If the field was not set prior to the call, then the returned Bar will have none of its fields set (i.e. it will be identical to a newly-allocated Bar). After calling this, has_foo() will return true and foo() will return a reference to the same instance of Bar.
   ```
   
   So in  BooleanColumnStatisticsImpl::BooleanColumnStatisticsImpl, https://github.com/apache/orc/blob/0aba9875be4396c40adedae5a257e622d43b64eb/c%2B%2B/src/Statistics.cc#L197, pb.has_bucketstatistics() is true. But pb.bucketstatistics().count(0) will access to a invalid field.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [orc] dongjoon-hyun commented on issue #1556: SIGSEGV When read statistics of an all null boolean stripe.

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on issue #1556:
URL: https://github.com/apache/orc/issues/1556#issuecomment-1638824445

   Which Apache ORC versions are affected by this, @oushu1zhouzhanghua1 ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [orc] wgtmac commented on issue #1556: SIGSEGV When read statistics of an all null boolean stripe.

Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac commented on issue #1556:
URL: https://github.com/apache/orc/issues/1556#issuecomment-1614053061

   Thanks for reporting the issue! Would you like to create a PR with a fix?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [orc] wgtmac commented on issue #1556: SIGSEGV When read statistics of an all null boolean stripe.

Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac commented on issue #1556:
URL: https://github.com/apache/orc/issues/1556#issuecomment-1619360388

   Do you have an JIRA account? You may need to create an [JIRA](https://issues.apache.org/jira/projects/ORC/issues/) first and submit an PR linking to the JIRA title. @oushu1zhouzhanghua1 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [orc] dongjoon-hyun commented on issue #1556: SIGSEGV When read statistics of an all null boolean stripe.

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on issue #1556:
URL: https://github.com/apache/orc/issues/1556#issuecomment-1716983714

   Gentle ping, @oushu1zhouzhanghua1 .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] SIGSEGV When read statistics of an all null boolean stripe. [orc]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed issue #1556: SIGSEGV When read statistics of an all null boolean stripe.
URL: https://github.com/apache/orc/issues/1556


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] SIGSEGV When read statistics of an all null boolean stripe. [orc]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on issue #1556:
URL: https://github.com/apache/orc/issues/1556#issuecomment-1818189033

   Since there is not much activity, let's close this issue. I hope Java-version `orc-tools` can help the situations, @oushu1zhouzhanghua1 .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [orc] oushu1zhouzhanghua1 commented on issue #1556: SIGSEGV When read statistics of an all null boolean stripe.

Posted by "oushu1zhouzhanghua1 (via GitHub)" <gi...@apache.org>.
oushu1zhouzhanghua1 commented on issue #1556:
URL: https://github.com/apache/orc/issues/1556#issuecomment-1614056557

   > Thanks for reporting the issue! Would you like to create a PR with a fix?
   
   ok


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org