You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by "Ovilia (via GitHub)" <gi...@apache.org> on 2025/09/25 08:29:45 UTC
[PR] fix: update for new theme builder [echarts-www]
Ovilia opened a new pull request, #75:
URL: https://github.com/apache/echarts-www/pull/75
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
Re: [PR] fix: update for new theme builder [echarts-www]
Posted by "100pah (via GitHub)" <gi...@apache.org>.
100pah commented on code in PR #75:
URL: https://github.com/apache/echarts-www/pull/75#discussion_r2493515327
##########
bin/release.sh:
##########
@@ -49,7 +49,7 @@ if [ ! -d "${themeProjectDir}" ]; then
exit 1
fi
cd ${themeProjectDir}
-node build.js --release
+npm run release
Review Comment:
Oh, yes, I overlooked it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
Re: [PR] fix: update for new theme builder [echarts-www]
Posted by "Ovilia (via GitHub)" <gi...@apache.org>.
Ovilia merged PR #75:
URL: https://github.com/apache/echarts-www/pull/75
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
Re: [PR] fix: update for new theme builder [echarts-www]
Posted by "Ovilia (via GitHub)" <gi...@apache.org>.
Ovilia commented on code in PR #75:
URL: https://github.com/apache/echarts-www/pull/75#discussion_r2493213840
##########
bin/release.sh:
##########
@@ -49,7 +49,7 @@ if [ ! -d "${themeProjectDir}" ]; then
exit 1
fi
cd ${themeProjectDir}
-node build.js --release
+npm run release
Review Comment:
The last command is `cd ${themeProjectDir}` so `npm run release` actually runs the release script under `echarts-theme-builder` instead of `echarts-www` so it works well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
Re: [PR] fix: update for new theme builder [echarts-www]
Posted by "100pah (via GitHub)" <gi...@apache.org>.
100pah commented on code in PR #75:
URL: https://github.com/apache/echarts-www/pull/75#discussion_r2477036259
##########
bin/release.sh:
##########
@@ -49,7 +49,7 @@ if [ ! -d "${themeProjectDir}" ]; then
exit 1
fi
cd ${themeProjectDir}
-node build.js --release
+npm run release
Review Comment:
I do not quite understand:
`npm run release` seems call `bin/release.sh`.
Is it a dead loop after this changing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org