You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Darrel Schneider <ds...@pivotal.io> on 2016/11/01 17:45:18 UTC
Re: Review Request 53108: GEODE-2012: always write stat types to
archive
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53108/#review154425
-----------------------------------------------------------
Ship it!
Ship It!
- Darrel Schneider
On Oct. 31, 2016, 4:54 p.m., Kirk Lund wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53108/
> -----------------------------------------------------------
>
> (Updated Oct. 31, 2016, 4:54 p.m.)
>
>
> Review request for geode, Anthony Baker, Darrel Schneider, Jinmei Liao, Kevin Duling, Swapnil Bawaskar, and Dan Smith.
>
>
> Bugs: GEODE-2012
> https://issues.apache.org/jira/browse/GEODE-2012
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-2012: always write stat types to archive
>
> * alter NanoTimer and its use to make testing easier
> * remove extra spaces in localized string
> * import SuppressWarnings to make use of annotation cleaner
> * new test for rolling stat files: FileSizeLimitIntegrationTest
> * new test for rolling and deleting old stat files: DiskSpaceLimitIntegrationTest
> * new test to expose GEODE-2012 and confirm its fix: StatTypesAreRolledOverRegressionTest
>
>
> Diffs
> -----
>
> geode-core/src/main/java/org/apache/geode/internal/NanoTimer.java 12e91f8e05ee93370f56d0af171558e7741eb0f2
> geode-core/src/main/java/org/apache/geode/internal/i18n/LocalizedStrings.java 210539bf33896259d56a41d05546101c996ac553
> geode-core/src/main/java/org/apache/geode/internal/io/MainWithChildrenRollingFileHandler.java PRE-CREATION
> geode-core/src/main/java/org/apache/geode/internal/io/RollingFileHandler.java PRE-CREATION
> geode-core/src/main/java/org/apache/geode/internal/logging/ManagerLogWriter.java a000d2c01008730dcf2a0faab0ae7f5ade5fcae1
> geode-core/src/main/java/org/apache/geode/internal/statistics/HostStatSampler.java 6d7b9670385babdbe0f829e70b960dd379259d62
> geode-core/src/main/java/org/apache/geode/internal/statistics/SampleCollector.java 610e848b3185baca0852efef085502e6d33ca2aa
> geode-core/src/main/java/org/apache/geode/internal/statistics/SimpleStatSampler.java 7eaa1e0a914fd9ef01d1e7cfbd110329c43de493
> geode-core/src/main/java/org/apache/geode/internal/statistics/StatArchiveHandler.java 5520936ba9835354a4225ff52f3bdcaf0ccb616a
> geode-core/src/main/java/org/apache/geode/internal/statistics/StatArchiveWriter.java a4c15d13401f20ca6717fdddff040cf29bc26bf5
> geode-core/src/main/java/org/apache/geode/internal/statistics/StatMonitorHandler.java a2b0ae4d5cf5c40bed392292180a8987952e80a9
> geode-core/src/main/java/org/apache/geode/internal/util/concurrent/StoppableCountDownLatch.java 740fd7fdc98928de0054ca83d11716033225e373
> geode-core/src/test/java/org/apache/geode/internal/statistics/DiskSpaceLimitIntegrationTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/internal/statistics/FileSizeLimitIntegrationTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/internal/statistics/SampleCollectorTest.java ab84ea4355df17b93c75487fb01fbb59f943bafc
> geode-core/src/test/java/org/apache/geode/internal/statistics/StatMonitorHandlerTest.java 85e6f6d4a943989a129d7a752fc70a5330a3428f
> geode-core/src/test/java/org/apache/geode/internal/statistics/StatMonitorHandlerWithEnabledMonitorThreadTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/internal/statistics/StatTypesAreRolledOverRegressionTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/internal/statistics/StatisticsMonitorTest.java b570db2e0094326f30dd47935a1558d9d1b01d48
> geode-core/src/test/java/org/apache/geode/internal/statistics/ValueMonitorIntegrationTest.java cef5977bfbc86e956e79e9d50b1a9b99fdab55e6
>
> Diff: https://reviews.apache.org/r/53108/diff/
>
>
> Testing
> -------
>
> precheckin passed everything!
>
>
> Thanks,
>
> Kirk Lund
>
>