[jira] Resolved: (SLING-1280) Rename methods of (new) AuthenticationHandler interface

["Felix Meschberger (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SLING-1280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Felix Meschberger resolved SLING-1280.
--------------------------------------

    Resolution: Fixed

... and adapted the HTTP Basic and OpenID authentication handlers in Rev. 897158.

This should do it here.

> Rename methods of (new) AuthenticationHandler interface
> -------------------------------------------------------
>
>                 Key: SLING-1280
>                 URL: https://issues.apache.org/jira/browse/SLING-1280
>             Project: Sling
>          Issue Type: Improvement
>          Components: Commons, Extensions
>    Affects Versions: Extensions OpenID Authentication 1.0.0, Extensions httpauth 2.0.6, Commons Auth 1.0.0
>            Reporter: Felix Meschberger
>            Assignee: Felix Meschberger
>             Fix For: Extensions OpenID Authentication 1.0.0, Extensions httpauth 2.0.6, Commons Auth 1.0.0
>
>
> Currently the AuthenticationHandler interface defines the following methods:
>    authenticate - extract credentials from request
>    requestAuthentication - ask client for credentials
>    dropAuthentication - forget about current credentials
> The authenticate and requestAuthentication names are historic and date back to some internal code at the time where uthenticationHandler did not exist yet.
> IMHO these names are not that good. And since we are defining new API anyway, this might probaby be a good time to rename the methods.
>    extractCredentials - extract credentials from request
>    requestCredentials - ask client for credentials
>    dropCredentials - forget about current credentials
> See also the discussion at http://markmail.org/thread/bocbtx2q5js4i2gf

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.