You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2021/03/23 00:00:14 UTC

[GitHub] [cordova-plugin-camera] hajunho commented on pull request #715: (iOS) overlay view supporting to show the indicated image titled "overl…

hajunho commented on pull request #715:
URL: https://github.com/apache/cordova-plugin-camera/pull/715#issuecomment-804479753


   > Thanks for your PR - could you please elaborate what it does? It's not quite clear to me what addition it has or bug it fixes. Besides that, it would be good to keep the different platform all in sync, i.e., adding an Android implementation, too. (if suitable & feasible)
   
   Thank you for reviewing. I didn't touch the established codes. It's just an indirection layer. As you already know, the overlay view can be used for the additional view to putting the picture after the function "taking the picture". We use this for the watermark for that(I had adjusted Alpha value 0.38). Platform-specific codes are not applicable, I know. but I agree with your opinion to add this function to Android also. These codes have to be changed after using the additional function by the native developer. What I didn't decide things is what options have to be inserted. i.e Alpha value, images, location, size, watermark or location, or timestamp options. Those are very big considering but I or somebody have to do I think. These are base codes for that and no errors(No called basically)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org