You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@openoffice.apache.org by GitBox <gi...@apache.org> on 2021/10/05 19:48:06 UTC

[GitHub] [openoffice] ardovm commented on pull request #139: Occurence "OpenOffice.org" in dialog Writing Aids for new thesaurus

ardovm commented on pull request #139:
URL: https://github.com/apache/openoffice/pull/139#issuecomment-934728666


   Looks good to me, because the string is not translated.
   
   We could argue that translating this and other strings returned by `getServiceDisplayName(const Locale&)` methods would be a good idea: the `Locale` parameter is there for a reason... but IMHO it is not the purpose of this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org