[GitHub] [tomcat] markt-asf commented on a change in pull request #209: BZ 63778: Jre7Compat cannot find getPseudoColumns with zero parameters

[GitBox <gi...@apache.org>]

markt-asf commented on a change in pull request #209: BZ 63778: Jre7Compat cannot find getPseudoColumns with zero parameters
URL: https://github.com/apache/tomcat/pull/209#discussion_r329665560
 
 

 ##########
 File path: java/org/apache/tomcat/util/compat/Jre7Compat.java
 ##########
 @@ -32,6 +36,9 @@
 
 class Jre7Compat extends JreCompat {
 
+    private static final Log log = LogFactory.getLog(Jre7Compat.class);
+    private static final StringManager sm = StringManager.getManager(Jre7Compat.class);
 
 Review comment:
   No. It should be `sm` for consistency with the rest of the Tomcat code base.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org