You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by "Willem Jiang (JIRA)" <ji...@apache.org> on 2010/05/12 04:47:42 UTC
[jira] Created: (CAMEL-2712) The default charset name should be
UTF-8
The default charset name should be UTF-8
----------------------------------------
Key: CAMEL-2712
URL: https://issues.apache.org/activemq/browse/CAMEL-2712
Project: Apache Camel
Issue Type: Improvement
Components: camel-core
Reporter: Willem Jiang
Assignee: Willem Jiang
Fix For: 1.6.3, 2.3.0
Current camel just use the below code to return the defaultCharset.
{code}
Charset.defaultCharset().toString();
[code}
It will cause some trouble if there are two boxes with different defaultCharset want to talk to each other with default setting.
By setting the defaultCharset to be UTF-8 will work around this kind of issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2712) The default charset name should be
UTF-8
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=59300#action_59300 ]
Claus Ibsen commented on CAMEL-2712:
------------------------------------
At least you should do the same as in XMLConverter so its consistent
{code}
return ObjectHelper.getSystemProperty(DEFAULT_CHARSET_PROPERTY, "UTF-8")
{code}
And move that constant somewhere else. Maybe on Exchange as it has become where we stash commonly used constants.
> The default charset name should be UTF-8
> ----------------------------------------
>
> Key: CAMEL-2712
> URL: https://issues.apache.org/activemq/browse/CAMEL-2712
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Reporter: Willem Jiang
> Assignee: Willem Jiang
> Fix For: 1.6.3, 2.3.0
>
>
> Current camel just use the below code to return the defaultCharset.
> {code}
> Charset.defaultCharset().toString();
> {code}
> It will cause some trouble if there are two boxes with different defaultCharset want to talk to each other with default setting.
> By setting the defaultCharset to be UTF-8 will work around this kind of issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-2712) The default charset name should be
UTF-8
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Willem Jiang updated CAMEL-2712:
--------------------------------
Description:
Current camel just use the below code to return the defaultCharset.
{code}
Charset.defaultCharset().toString();
{code}
It will cause some trouble if there are two boxes with different defaultCharset want to talk to each other with default setting.
By setting the defaultCharset to be UTF-8 will work around this kind of issue.
was:
Current camel just use the below code to return the defaultCharset.
{code}
Charset.defaultCharset().toString();
[code}
It will cause some trouble if there are two boxes with different defaultCharset want to talk to each other with default setting.
By setting the defaultCharset to be UTF-8 will work around this kind of issue.
> The default charset name should be UTF-8
> ----------------------------------------
>
> Key: CAMEL-2712
> URL: https://issues.apache.org/activemq/browse/CAMEL-2712
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Reporter: Willem Jiang
> Assignee: Willem Jiang
> Fix For: 1.6.3, 2.3.0
>
>
> Current camel just use the below code to return the defaultCharset.
> {code}
> Charset.defaultCharset().toString();
> {code}
> It will cause some trouble if there are two boxes with different defaultCharset want to talk to each other with default setting.
> By setting the defaultCharset to be UTF-8 will work around this kind of issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2712) The default charset name should be
UTF-8
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=59306#action_59306 ]
Willem Jiang commented on CAMEL-2712:
-------------------------------------
@Claus,
Good suggestion, I'm heading to commit a new patch for it.
> The default charset name should be UTF-8
> ----------------------------------------
>
> Key: CAMEL-2712
> URL: https://issues.apache.org/activemq/browse/CAMEL-2712
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Reporter: Willem Jiang
> Assignee: Willem Jiang
> Fix For: 1.6.3, 2.3.0
>
>
> Current camel just use the below code to return the defaultCharset.
> {code}
> Charset.defaultCharset().toString();
> {code}
> It will cause some trouble if there are two boxes with different defaultCharset want to talk to each other with default setting.
> By setting the defaultCharset to be UTF-8 will work around this kind of issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2712) The default charset name should be
UTF-8
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=59297#action_59297 ]
Claus Ibsen commented on CAMEL-2712:
------------------------------------
Hmmm I dont think its advised to mess with the default charset?
At least do not commit it directly but attach a patch we can take a look and discuss.
> The default charset name should be UTF-8
> ----------------------------------------
>
> Key: CAMEL-2712
> URL: https://issues.apache.org/activemq/browse/CAMEL-2712
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Reporter: Willem Jiang
> Assignee: Willem Jiang
> Fix For: 1.6.3, 2.3.0
>
>
> Current camel just use the below code to return the defaultCharset.
> {code}
> Charset.defaultCharset().toString();
> {code}
> It will cause some trouble if there are two boxes with different defaultCharset want to talk to each other with default setting.
> By setting the defaultCharset to be UTF-8 will work around this kind of issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CAMEL-2712) The default charset name should be
UTF-8
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Willem Jiang resolved CAMEL-2712.
---------------------------------
Resolution: Fixed
committed the new patch and updated the wiki page for it.
> The default charset name should be UTF-8
> ----------------------------------------
>
> Key: CAMEL-2712
> URL: https://issues.apache.org/activemq/browse/CAMEL-2712
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Reporter: Willem Jiang
> Assignee: Willem Jiang
> Fix For: 1.6.3, 2.3.0
>
>
> Current camel just use the below code to return the defaultCharset.
> {code}
> Charset.defaultCharset().toString();
> {code}
> It will cause some trouble if there are two boxes with different defaultCharset want to talk to each other with default setting.
> By setting the defaultCharset to be UTF-8 will work around this kind of issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2712) The default charset name should be
UTF-8
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=59299#action_59299 ]
Willem Jiang commented on CAMEL-2712:
-------------------------------------
oh, I already committed the code, it just a single line's change.
{code}
--- camel/trunk/camel-core/src/main/java/org/apache/camel/converter/IOConverter.java (original)
+++ camel/trunk/camel-core/src/main/java/org/apache/camel/converter/IOConverter.java Wed May 12 07:05:19 2010
@@ -338,7 +338,7 @@ public final class IOConverter {
}
public static String getDefaultCharsetName() {
- return Charset.defaultCharset().toString();
+ return "UTF-8";
}
/**
{code}
It just make sure we treat the default string with UTF-8 encoding, we did the same thing in the XMLConverter
{code}
public static String defaultCharset = ObjectHelper.getSystemProperty(DEFAULT_CHARSET_PROPERTY, "UTF-8");
{code}
> The default charset name should be UTF-8
> ----------------------------------------
>
> Key: CAMEL-2712
> URL: https://issues.apache.org/activemq/browse/CAMEL-2712
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Reporter: Willem Jiang
> Assignee: Willem Jiang
> Fix For: 1.6.3, 2.3.0
>
>
> Current camel just use the below code to return the defaultCharset.
> {code}
> Charset.defaultCharset().toString();
> {code}
> It will cause some trouble if there are two boxes with different defaultCharset want to talk to each other with default setting.
> By setting the defaultCharset to be UTF-8 will work around this kind of issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2712) The default charset name should be
UTF-8
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=59301#action_59301 ]
Claus Ibsen commented on CAMEL-2712:
------------------------------------
And add a note about this change in the 2.3 release notes
> The default charset name should be UTF-8
> ----------------------------------------
>
> Key: CAMEL-2712
> URL: https://issues.apache.org/activemq/browse/CAMEL-2712
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Reporter: Willem Jiang
> Assignee: Willem Jiang
> Fix For: 1.6.3, 2.3.0
>
>
> Current camel just use the below code to return the defaultCharset.
> {code}
> Charset.defaultCharset().toString();
> {code}
> It will cause some trouble if there are two boxes with different defaultCharset want to talk to each other with default setting.
> By setting the defaultCharset to be UTF-8 will work around this kind of issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.