You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bigtop.apache.org by GitBox <gi...@apache.org> on 2022/09/01 07:45:01 UTC
[GitHub] [bigtop] kevinw66 opened a new pull request, #997: BIGTOP-3798: Support parent directory configuration for Zeppelin rpm build script
kevinw66 opened a new pull request, #997:
URL: https://github.com/apache/bigtop/pull/997
<!--
Thanks for sending a pull request!
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/BIGTOP/How+to+Contribute
2. Make sure your PR title starts with JIRA issue id, e.g., 'BIGTOP-3638: Your PR title ...'.
-->
### Description of PR
### How was this patch tested?
Tested with #994
diff result:
```
1804877 blocks
1804877 blocks
```
### For code changes:
- [ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'BIGTOP-3638. Your PR title ...')?
- [ ] Make sure that newly added files do not have any licensing issues. When in doubt refer to https://www.apache.org/licenses/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] sekikn merged pull request #997: BIGTOP-3798: Support parent directory configuration for Zeppelin rpm build script
Posted by GitBox <gi...@apache.org>.
sekikn merged PR #997:
URL: https://github.com/apache/bigtop/pull/997
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] sekikn commented on pull request #997: BIGTOP-3798: Support parent directory configuration for Zeppelin rpm build script
Posted by GitBox <gi...@apache.org>.
sekikn commented on PR #997:
URL: https://github.com/apache/bigtop/pull/997#issuecomment-1244876216
+1, no difference in the RPM packages between the original and patched versions (without the `parentDir` option). The latter also passed the smoke test.
```
$ ./gradlew zeppelin-clean zeppelin-pkg repo -Dbuildwithdeps=true
...
BUILD SUCCESSFUL in 1h 36m 51s
49 actionable tasks: 49 executed
$ mv output/zeppelin ~
$ curl -sL https://github.com/apache/bigtop/pull/997.patch | git apply
$ git diff --stat
bigtop-packages/src/common/zeppelin/install_zeppelin.sh | 47 +++++++++++++++++++++++++++--------------------
bigtop-packages/src/rpm/zeppelin/SPECS/zeppelin.spec | 56 +++++++++++++++++++++++++++++++++-----------------------
2 files changed, 60 insertions(+), 43 deletions(-)
$ ./gradlew zeppelin-clean zeppelin-pkg repo
...
BUILD SUCCESSFUL in 1h 38m 36s
9 actionable tasks: 9 executed
$ diff <(rpm -qlp output/zeppelin/x86_64/zeppelin-0.10.1-1.fc35.x86_64.rpm) <(rpm -qlp ~/zeppelin/x86_64/zeppelin-0.10.1-1.fc35.x86_64.rpm)
$ cd provisioner/docker
$ ./docker-hadoop.sh -d -C config_fedora-35.yaml -F docker-compose-cgroupv2.yml -r file:///bigtop-home/output -G -k zeppelin -s zeppelin -c 1
...
> Task :bigtop-tests:smoke-tests:zeppelin:test
Finished generating test XML results (0.013 secs) into: /bigtop-home/bigtop-tests/smoke-tests/zeppelin/build/test-results/test
Generating HTML test report...
Finished generating test html results (0.034 secs) into: /bigtop-home/bigtop-tests/smoke-tests/zeppelin/build/reports/tests/test
Now testing...
:bigtop-tests:smoke-tests:zeppelin:test (Thread[Daemon worker,5,main]) completed. Took 15.798 secs.
BUILD SUCCESSFUL in 2m 14s
30 actionable tasks: 5 executed, 25 up-to-date
```
The `parentDir` option also works fine.
```
$ ./gradlew zeppelin-clean zeppelin-pkg -PparentDir=/usr/bigtop
...
BUILD SUCCESSFUL in 1h 34m 58s
7 actionable tasks: 7 executed
$ rpm -qlpv output/zeppelin/x86_64/zeppelin-0.10.1-1.fc35.x86_64.rpm
-rwxr-xr-x 1 root root 4115 Sep 13 01:15 /etc/rc.d/init.d/zeppelin
drwxr-xr-x 2 zeppelin zeppelin 0 Sep 13 01:15 /etc/zeppelin
drwxr-xr-x 2 zeppelin zeppelin 0 Sep 13 01:15 /usr/bigtop/etc/zeppelin/conf.dist
...
-rwxr-xr-x 1 zeppelin zeppelin 26753 Feb 24 2022 /usr/bigtop/etc/zeppelin/conf.dist/zeppelin-site.xml.template
drwxr-xr-x 2 root root 0 Sep 13 01:15 /usr/bigtop/usr/lib/zeppelin/bin
...
-rw-r--r-- 1 root root 29696461 Sep 13 01:14 /usr/bigtop/usr/lib/zeppelin/zeppelin-web-0.10.1.war
drwxr-xr-x 2 root root 0 Sep 13 01:15 /usr/bigtop/usr/share/doc/zeppelin-0.10.1
...
-rw-r--r-- 1 root root 1271 Feb 24 2022 /usr/bigtop/usr/share/doc/zeppelin-0.10.1/licenses/LICENSE-sqlline-1.0.2
drwxr-xr-x 2 zeppelin zeppelin 0 Sep 13 01:15 /usr/bigtop/var/lib/zeppelin
...
-rwxr-xr-x 1 zeppelin zeppelin 155923 Feb 24 2022 /usr/bigtop/var/lib/zeppelin/notebook/Spark Tutorial/8. PySpark Conda Env in Yarn Mode_2GE79Y5FV.zpln
drwxr-xr-x 2 zeppelin zeppelin 0 Sep 13 01:15 /var/log/zeppelin
drwxr-xr-x 2 zeppelin zeppelin 0 Sep 13 01:15 /var/run/zeppelin
drwxr-xr-x 2 zeppelin zeppelin 0 Sep 13 01:15 /var/run/zeppelin/webapps
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] sekikn commented on pull request #997: BIGTOP-3798: Support parent directory configuration for Zeppelin rpm build script
Posted by GitBox <gi...@apache.org>.
sekikn commented on PR #997:
URL: https://github.com/apache/bigtop/pull/997#issuecomment-1244876369
Merged into master. Thanks @kevinw66!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org