You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/01/02 03:25:50 UTC
[GitHub] [arrow-rs] liukun4515 commented on a change in pull request #1112: allow using custom datetime format for inference and parsing csv file
liukun4515 commented on a change in pull request #1112:
URL: https://github.com/apache/arrow-rs/pull/1112#discussion_r777161244
##########
File path: arrow/src/csv/reader.rs
##########
@@ -1522,18 +1624,26 @@ mod tests {
#[test]
fn test_infer_field_schema() {
- assert_eq!(infer_field_schema("A"), DataType::Utf8);
- assert_eq!(infer_field_schema("\"123\""), DataType::Utf8);
- assert_eq!(infer_field_schema("10"), DataType::Int64);
- assert_eq!(infer_field_schema("10.2"), DataType::Float64);
- assert_eq!(infer_field_schema(".2"), DataType::Float64);
- assert_eq!(infer_field_schema("2."), DataType::Float64);
- assert_eq!(infer_field_schema("true"), DataType::Boolean);
- assert_eq!(infer_field_schema("false"), DataType::Boolean);
- assert_eq!(infer_field_schema("2020-11-08"), DataType::Date32);
- assert_eq!(infer_field_schema("2020-11-08T14:20:01"), DataType::Date64);
- assert_eq!(infer_field_schema("-5.13"), DataType::Float64);
- assert_eq!(infer_field_schema("0.1300"), DataType::Float64);
+ assert_eq!(infer_field_schema("A", None), DataType::Utf8);
+ assert_eq!(infer_field_schema("\"123\"", None), DataType::Utf8);
+ assert_eq!(infer_field_schema("10", None), DataType::Int64);
+ assert_eq!(infer_field_schema("10.2", None), DataType::Float64);
+ assert_eq!(infer_field_schema(".2", None), DataType::Float64);
+ assert_eq!(infer_field_schema("2.", None), DataType::Float64);
+ assert_eq!(infer_field_schema("true", None), DataType::Boolean);
+ assert_eq!(infer_field_schema("false", None), DataType::Boolean);
+ assert_eq!(infer_field_schema("2020-11-08", None), DataType::Date32);
+ assert_eq!(
+ infer_field_schema("2020-11-08T14:20:01", None),
+ DataType::Date64
+ );
+ let reg = Regex::new(r"^\d{4}-\d\d-\d\d \d\d:\d\d:\d\d$").ok();
Review comment:
it's great.
No more needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org