You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "MasterJH5574 (via GitHub)" <gi...@apache.org> on 2024/08/16 17:59:12 UTC

[PR] [Codegen] Emit `tir::Let` as var assignment explicitly [tvm]

MasterJH5574 opened a new pull request, #17278:
URL: https://github.com/apache/tvm/pull/17278

   Prior to this PR, the PrimExpr `tir::Let` is treated as inlining during codegen, which makes any common subexpression elimination (CSE) efforts using `tir::Let` at TIR level effectless.
   
   This PR updates codegen so that the `tir::Let` will have an explicit var assignment and thus can effectively reflect the CSE efforts.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Codegen] Emit `tir::Let` as var assignment explicitly [tvm]

Posted by "tqchen (via GitHub)" <gi...@apache.org>.
tqchen merged PR #17278:
URL: https://github.com/apache/tvm/pull/17278


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Codegen] Emit `tir::Let` as var assignment explicitly [tvm]

Posted by "Lunderberg (via GitHub)" <gi...@apache.org>.
Lunderberg commented on PR #17278:
URL: https://github.com/apache/tvm/pull/17278#issuecomment-2302189380

   I'm a little bit late on the review, but I like the fix, thank you!  I double-checked `codegen_llvm.cc`, and it tracks `tir::Let` expressions by their `llvm::Value*`, and wouldn't be susceptible to the same issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Codegen] Emit `tir::Let` as var assignment explicitly [tvm]

Posted by "tqchen (via GitHub)" <gi...@apache.org>.
tqchen commented on PR #17278:
URL: https://github.com/apache/tvm/pull/17278#issuecomment-2299601044

   @tvm-bot rerun


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org