You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ross Allen <ro...@mesosphere.io> on 2013/11/14 20:21:32 UTC
Review Request 15526: Added terminated frameworks to frameworks tab.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15526/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos-git
Description
-------
Added terminated frameworks to frameworks tab.
In preparation for moving frameworks off the homepage, terminated
frameworks will now be listed on /frameworks.html.
The code was copy/pasted from home.html.
Diffs
-----
src/webui/master/static/frameworks.html 7c243d47d80e7c74fcac938d012b91b67b995490
Diff: https://reviews.apache.org/r/15526/diff/
Testing
-------
Thanks,
Ross Allen
Re: Review Request 15526: Added terminated frameworks to frameworks tab.
Posted by Ross Allen <ro...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15526/
-----------------------------------------------------------
(Updated Nov. 14, 2013, 11:25 p.m.)
Review request for mesos.
Repository: mesos-git
Description
-------
Added terminated frameworks to frameworks tab.
In preparation for moving frameworks off the homepage, terminated
frameworks will now be listed on /frameworks.html.
The code was copy/pasted from home.html.
Diffs
-----
src/webui/master/static/frameworks.html 7c243d47d80e7c74fcac938d012b91b67b995490
Diff: https://reviews.apache.org/r/15526/diff/
Testing (updated)
-------
Ran a framework
Killed the framework
Found the terminated framework on /frameworks
Thanks,
Ross Allen
Re: Review Request 15526: Added terminated frameworks to frameworks tab.
Posted by Ross Allen <ro...@mesosphere.io>.
> On Nov. 14, 2013, 7:45 p.m., Ben Mahler wrote:
> > You've tested this, right? :)
Copy/pasted was a bad term to use. I said that intending to mean, "all the features are the same".
I tested it, and I'll add that to the "Testing done" field.
- Ross
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15526/#review28890
-----------------------------------------------------------
On Nov. 14, 2013, 7:21 p.m., Ross Allen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15526/
> -----------------------------------------------------------
>
> (Updated Nov. 14, 2013, 7:21 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Added terminated frameworks to frameworks tab.
>
> In preparation for moving frameworks off the homepage, terminated
> frameworks will now be listed on /frameworks.html.
>
> The code was copy/pasted from home.html.
>
>
> Diffs
> -----
>
> src/webui/master/static/frameworks.html 7c243d47d80e7c74fcac938d012b91b67b995490
>
> Diff: https://reviews.apache.org/r/15526/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ross Allen
>
>
Re: Review Request 15526: Added terminated frameworks to frameworks tab.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15526/#review28890
-----------------------------------------------------------
Ship it!
You've tested this, right? :)
- Ben Mahler
On Nov. 14, 2013, 7:21 p.m., Ross Allen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15526/
> -----------------------------------------------------------
>
> (Updated Nov. 14, 2013, 7:21 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Added terminated frameworks to frameworks tab.
>
> In preparation for moving frameworks off the homepage, terminated
> frameworks will now be listed on /frameworks.html.
>
> The code was copy/pasted from home.html.
>
>
> Diffs
> -----
>
> src/webui/master/static/frameworks.html 7c243d47d80e7c74fcac938d012b91b67b995490
>
> Diff: https://reviews.apache.org/r/15526/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ross Allen
>
>