You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@libcloud.apache.org by GitBox <gi...@apache.org> on 2020/01/17 10:00:24 UTC
[GitHub] [libcloud] micafer opened a new pull request #1412: Fix error
getting node_id in OpenStack_1_1_FloatingIpAddress: #1411
micafer opened a new pull request #1412: Fix error getting node_id in OpenStack_1_1_FloatingIpAddress: #1411
URL: https://github.com/apache/libcloud/pull/1412
## Fix error getting node_id in OpenStack_1_1_FloatingIpAddress in case of region is not called "nova".
### Description
In the function OpenStack_2_FloatingIpPool._to_floating_ip the instance_id of the node where the IP is attached to is not correctly obtained if the name of the region is not the expected one "nova".
### Status
- done, ready for review
### Checklist (tick everything that applies)
- [x] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide) (required, can be done after the PR checks)
- [ ] Documentation
- [x] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
- [x] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes) (required for bigger changes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [libcloud] codecov-io commented on issue #1412: Fix error getting
node_id in OpenStack_1_1_FloatingIpAddress: #1411
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1412: Fix error getting node_id in OpenStack_1_1_FloatingIpAddress: #1411
URL: https://github.com/apache/libcloud/pull/1412#issuecomment-575559539
# [Codecov](https://codecov.io/gh/apache/libcloud/pull/1412?src=pr&el=h1) Report
> Merging [#1412](https://codecov.io/gh/apache/libcloud/pull/1412?src=pr&el=desc) into [trunk](https://codecov.io/gh/apache/libcloud/commit/bb865b1ee029b9bceaa83917c9b9f7b16033547e?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `83.33%`.
[](https://codecov.io/gh/apache/libcloud/pull/1412?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## trunk #1412 +/- ##
==========================================
+ Coverage 86.46% 86.46% +<.01%
==========================================
Files 366 366
Lines 76791 76796 +5
Branches 7529 7529
==========================================
+ Hits 66396 66401 +5
Misses 7527 7527
Partials 2868 2868
```
| [Impacted Files](https://codecov.io/gh/apache/libcloud/pull/1412?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [libcloud/test/compute/test\_openstack.py](https://codecov.io/gh/apache/libcloud/pull/1412/diff?src=pr&el=tree#diff-bGliY2xvdWQvdGVzdC9jb21wdXRlL3Rlc3Rfb3BlbnN0YWNrLnB5) | `94.73% <100%> (+0.01%)` | :arrow_up: |
| [libcloud/compute/drivers/openstack.py](https://codecov.io/gh/apache/libcloud/pull/1412/diff?src=pr&el=tree#diff-bGliY2xvdWQvY29tcHV0ZS9kcml2ZXJzL29wZW5zdGFjay5weQ==) | `85.72% <50%> (+0.01%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/libcloud/pull/1412?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/libcloud/pull/1412?src=pr&el=footer). Last update [bb865b1...f5b0631](https://codecov.io/gh/apache/libcloud/pull/1412?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [libcloud] Kami merged pull request #1412: Fix error getting
node_id in OpenStack_1_1_FloatingIpAddress: #1411
Posted by GitBox <gi...@apache.org>.
Kami merged pull request #1412: Fix error getting node_id in OpenStack_1_1_FloatingIpAddress: #1411
URL: https://github.com/apache/libcloud/pull/1412
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services