You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/02/15 10:22:49 UTC
[GitHub] [spark] c21 opened a new pull request #35529: [SPARK-38124][SS][FOLLOWUP] Add test to harden assumption of SS partitioning requirement
c21 opened a new pull request #35529:
URL: https://github.com/apache/spark/pull/35529
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This is a followup of https://github.com/apache/spark/pull/35419#discussion_r801354342, to add unit test to harden the assumption of SS partitioning and distribution requirement:
* Check the `HashPartitioning.partitionIdExpression` to be exactly expected format
* Check all different kinds of `Partitioning` against `StatefulOpClusteredDistribution`.
Also add a minor comment for `StatefulOpClusteredDistribution`, as `SinglePartition` can also satisfy the distribution.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Document our assumption of SS in code as unit test.
So next time when we introduce intrusive code change, the unit test can save us by failing loudly.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
The added unit test itself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] c21 commented on a change in pull request #35529: [SPARK-38124][SS][FOLLOWUP] Add test to harden assumption of SS partitioning requirement
Posted by GitBox <gi...@apache.org>.
c21 commented on a change in pull request #35529:
URL: https://github.com/apache/spark/pull/35529#discussion_r806676280
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/DistributionSuite.scala
##########
@@ -265,4 +267,80 @@ class DistributionSuite extends SparkFunSuite {
ClusteredDistribution(Seq($"a", $"b", $"c"), Some(5)),
false)
}
+
+ test("Structured Streaming output partitioning and distribution") {
+ // Validate HashPartitioning.partitionIdExpression to be exactly expected format, because
+ // Structured Streaming state store requires it to be consistent across Spark versions.
+ val expressions = Seq($"a", $"b", $"c")
+ val hashPartitioning = HashPartitioning(expressions, 10)
+ hashPartitioning.partitionIdExpression match {
+ case Pmod(Murmur3Hash(es, 42), Literal(10, IntegerType), _) =>
+ assert(es.length == expressions.length && es.zip(expressions).forall {
+ case (l, r) => l.semanticEquals(r)
+ })
+ case x => fail(s"Unexpected partitionIdExpression $x for $hashPartitioning")
+ }
+
+ // Validate only HashPartitioning (and HashPartitioning in PartitioningCollection) can satisfy
Review comment:
Covered all subclasses of `Partitioning` here, except `DataSourcePartitioning`, because `DataSourcePartitioning` is not accessible from this unit test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] c21 commented on pull request #35529: [SPARK-38124][SS][FOLLOWUP] Add test to harden assumption of SS partitioning requirement
Posted by GitBox <gi...@apache.org>.
c21 commented on pull request #35529:
URL: https://github.com/apache/spark/pull/35529#issuecomment-1040103287
cc @cloud-fan, @sunchao, @viirya, @HyukjinKwon and @HeartSaVioR, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] c21 commented on pull request #35529: [SPARK-38124][SS][FOLLOWUP] Add test to harden assumption of SS partitioning requirement
Posted by GitBox <gi...@apache.org>.
c21 commented on pull request #35529:
URL: https://github.com/apache/spark/pull/35529#issuecomment-1040103287
cc @cloud-fan, @sunchao, @viirya, @HyukjinKwon and @HeartSaVioR, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HeartSaVioR closed pull request #35529: [SPARK-38124][SS][FOLLOWUP] Add test to harden assumption of SS partitioning requirement
Posted by GitBox <gi...@apache.org>.
HeartSaVioR closed pull request #35529:
URL: https://github.com/apache/spark/pull/35529
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] c21 commented on a change in pull request #35529: [SPARK-38124][SS][FOLLOWUP] Add test to harden assumption of SS partitioning requirement
Posted by GitBox <gi...@apache.org>.
c21 commented on a change in pull request #35529:
URL: https://github.com/apache/spark/pull/35529#discussion_r806676280
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/DistributionSuite.scala
##########
@@ -265,4 +267,80 @@ class DistributionSuite extends SparkFunSuite {
ClusteredDistribution(Seq($"a", $"b", $"c"), Some(5)),
false)
}
+
+ test("Structured Streaming output partitioning and distribution") {
+ // Validate HashPartitioning.partitionIdExpression to be exactly expected format, because
+ // Structured Streaming state store requires it to be consistent across Spark versions.
+ val expressions = Seq($"a", $"b", $"c")
+ val hashPartitioning = HashPartitioning(expressions, 10)
+ hashPartitioning.partitionIdExpression match {
+ case Pmod(Murmur3Hash(es, 42), Literal(10, IntegerType), _) =>
+ assert(es.length == expressions.length && es.zip(expressions).forall {
+ case (l, r) => l.semanticEquals(r)
+ })
+ case x => fail(s"Unexpected partitionIdExpression $x for $hashPartitioning")
+ }
+
+ // Validate only HashPartitioning (and HashPartitioning in PartitioningCollection) can satisfy
Review comment:
Covered all subclasses of `Partitioning` here, except `DataSourcePartitioning`, because `DataSourcePartitioning` is not accessible from this unit test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HeartSaVioR commented on pull request #35529: [SPARK-38124][SS][FOLLOWUP] Add test to harden assumption of SS partitioning requirement
Posted by GitBox <gi...@apache.org>.
HeartSaVioR commented on pull request #35529:
URL: https://github.com/apache/spark/pull/35529#issuecomment-1040884018
Thanks! Merging to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] c21 commented on pull request #35529: [SPARK-38124][SS][FOLLOWUP] Add test to harden assumption of SS partitioning requirement
Posted by GitBox <gi...@apache.org>.
c21 commented on pull request #35529:
URL: https://github.com/apache/spark/pull/35529#issuecomment-1040885792
Thank you all for review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org