You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "fisjac (via GitHub)" <gi...@apache.org> on 2024/05/09 16:28:55 UTC
[PR] fix(ar-modal): updateNotificationSettings not updating state [superset]
fisjac opened a new pull request, #28409:
URL: https://github.com/apache/superset/pull/28409
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
When changing the recipients list for an existing notification method, the state is not being changed properly. This change addresses this by reinstating missing code that was lost in a previous PR.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [x] Has associated issue: https://github.com/apache/superset/issues/28149#issuecomment-2100612644
- [x] Required feature flags: ALERT_REPORTS
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(ar-modal): updateNotificationSettings not updating state [superset]
Posted by "alexkyurtev (via GitHub)" <gi...@apache.org>.
alexkyurtev commented on PR #28409:
URL: https://github.com/apache/superset/pull/28409#issuecomment-2107372672
Hello , when do you expect the PR to be merged ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(ar-modal): updateNotificationSettings not updating state [superset]
Posted by "alexkyurtev (via GitHub)" <gi...@apache.org>.
alexkyurtev commented on PR #28409:
URL: https://github.com/apache/superset/pull/28409#issuecomment-2109372418
Hello , I suppose that the changes are live now ? Or ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(ar-modal): updateNotificationSettings not updating state [superset]
Posted by "Nick-ATOR (via GitHub)" <gi...@apache.org>.
Nick-ATOR commented on PR #28409:
URL: https://github.com/apache/superset/pull/28409#issuecomment-2136186146
Is there any way to directly implement this fix in a K8s deployment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(ar-modal): updateNotificationSettings not updating state [superset]
Posted by "sfirke (via GitHub)" <gi...@apache.org>.
sfirke commented on PR #28409:
URL: https://github.com/apache/superset/pull/28409#issuecomment-2115462893
These changes would be live on master branch (you could run the nightly, unstable build image `apache/superset:latest` to verify) but did not make it into 4.0.1. They will be present in 4.0.2 and 4.1.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(ar-modal): updateNotificationSettings not updating state [superset]
Posted by "sfirke (via GitHub)" <gi...@apache.org>.
sfirke commented on PR #28409:
URL: https://github.com/apache/superset/pull/28409#issuecomment-2136294042
If a community member wanted to take the 4.0.1 release, cherry-pick this PR onto it, and package it up for the world, that might be widely useful. I hope 4.0.2 and 4.1.0 come out soon but in the meantime someone could run with that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(ar-modal): updateNotificationSettings not updating state [superset]
Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch merged PR #28409:
URL: https://github.com/apache/superset/pull/28409
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org