[jira] [Commented] (CB-13230) Remove service worker from cordova-browser

["Herm Wong (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-13230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16147738#comment-16147738 ] 

Herm Wong commented on CB-13230:
--------------------------------

Tested using the following instructions:

1) create a cordova app
2) add your local browser `cordova platform add pathToBrowser`
3) cordova run
4) you should see hello world open up in your default browser (chrome?)
5) make a change to www/index.js (change the h1 tag or something silly)
6) cordova run
7) the app won't show your change

I wasn't able to reproduce the issue using OSX Google Chrome version: 60.0.3112.101 (Official Build) (64-bit)

> Remove service worker from cordova-browser
> ------------------------------------------
>
>                 Key: CB-13230
>                 URL: https://issues.apache.org/jira/browse/CB-13230
>             Project: Apache Cordova
>          Issue Type: Bug
>    Affects Versions: 5.0.0
>            Reporter: Steve Gill
>            Assignee: Herm Wong
>              Labels: browser-next
>             Fix For: 5.1.0
>
>
> It doesn't make sense to include service workers by default in cordova-browser. We are better off documenting how to add service workers so our users can do that. I think we need to delete https://github.com/apache/cordova-browser/blob/master/bin/template/www/cordova-sw.js and remove any references to cordova-sw.js https://github.com/apache/cordova-browser/search?utf8=%E2%9C%93&q=cordova-sw.js&type=



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org