You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Gabor Szadovszky <ga...@cloudera.com> on 2016/07/27 13:05:25 UTC

Review Request 50502: HIVE-14294: HiveSchemaConverter for Parquet doesn't translate TINYINT and SMALLINT into proper Parquet types

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50502/
-----------------------------------------------------------

Review request for hive, Aihua Xu, Cheng Lian, and Sergio Pena.


Bugs: HIVE-14294
    https://issues.apache.org/jira/browse/HIVE-14294


Repository: hive-git


Description
-------

HIVE-14294: HiveSchemaConverter for Parquet doesn't translate TINYINT and SMALLINT into proper Parquet types


Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/io/parquet/convert/HiveSchemaConverter.java 40f6256cc3d9e11e0f9760bfeab364316ebc638c 
  ql/src/test/org/apache/hadoop/hive/ql/io/parquet/TestHiveSchemaConverter.java 589b5b59a4757986c22355fd1557265efbd0c537 

Diff: https://reviews.apache.org/r/50502/diff/


Testing
-------

Unit tests updated; see patch for details. + manual tests


Thanks,

Gabor Szadovszky


Re: Review Request 50502: HIVE-14294: HiveSchemaConverter for Parquet doesn't translate TINYINT and SMALLINT into proper Parquet types

Posted by Aihua Xu <ax...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50502/#review143729
-----------------------------------------------------------


Ship it!




Ship It!

- Aihua Xu


On July 27, 2016, 1:05 p.m., Gabor Szadovszky wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50502/
> -----------------------------------------------------------
> 
> (Updated July 27, 2016, 1:05 p.m.)
> 
> 
> Review request for hive, Aihua Xu, Cheng Lian, and Sergio Pena.
> 
> 
> Bugs: HIVE-14294
>     https://issues.apache.org/jira/browse/HIVE-14294
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-14294: HiveSchemaConverter for Parquet doesn't translate TINYINT and SMALLINT into proper Parquet types
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/io/parquet/convert/HiveSchemaConverter.java 40f6256cc3d9e11e0f9760bfeab364316ebc638c 
>   ql/src/test/org/apache/hadoop/hive/ql/io/parquet/TestHiveSchemaConverter.java 589b5b59a4757986c22355fd1557265efbd0c537 
> 
> Diff: https://reviews.apache.org/r/50502/diff/
> 
> 
> Testing
> -------
> 
> Unit tests updated; see patch for details. + manual tests
> 
> 
> Thanks,
> 
> Gabor Szadovszky
> 
>


Re: Review Request 50502: HIVE-14294: HiveSchemaConverter for Parquet doesn't translate TINYINT and SMALLINT into proper Parquet types

Posted by Cheng Lian <li...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50502/#review143754
-----------------------------------------------------------


Ship it!




Ship It!

- Cheng Lian


On July 27, 2016, 1:05 p.m., Gabor Szadovszky wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50502/
> -----------------------------------------------------------
> 
> (Updated July 27, 2016, 1:05 p.m.)
> 
> 
> Review request for hive, Aihua Xu, Cheng Lian, and Sergio Pena.
> 
> 
> Bugs: HIVE-14294
>     https://issues.apache.org/jira/browse/HIVE-14294
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-14294: HiveSchemaConverter for Parquet doesn't translate TINYINT and SMALLINT into proper Parquet types
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/io/parquet/convert/HiveSchemaConverter.java 40f6256cc3d9e11e0f9760bfeab364316ebc638c 
>   ql/src/test/org/apache/hadoop/hive/ql/io/parquet/TestHiveSchemaConverter.java 589b5b59a4757986c22355fd1557265efbd0c537 
> 
> Diff: https://reviews.apache.org/r/50502/diff/
> 
> 
> Testing
> -------
> 
> Unit tests updated; see patch for details. + manual tests
> 
> 
> Thanks,
> 
> Gabor Szadovszky
> 
>