You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@directory.apache.org by "Emmanuel Lecharny (JIRA)" <ji...@apache.org> on 2007/02/07 13:19:05 UTC

[jira] Created: (DIRSERVER-843) NPE in DnNormalizer

NPE in DnNormalizer
-------------------

                 Key: DIRSERVER-843
                 URL: https://issues.apache.org/jira/browse/DIRSERVER-843
             Project: Directory ApacheDS
          Issue Type: Bug
            Reporter: Emmanuel Lecharny


If we try to normalize a DN which is not an instance of String, Name or LdapDN? we might get a NPE. 

We should throw an exception instead of allowing such NPE.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (DIRSERVER-843) NPE in DnNormalizer

Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DIRSERVER-843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Emmanuel Lecharny resolved DIRSERVER-843.
-----------------------------------------

    Resolution: Fixed

It has already been fixed in 1.5.0

> NPE in DnNormalizer
> -------------------
>
>                 Key: DIRSERVER-843
>                 URL: https://issues.apache.org/jira/browse/DIRSERVER-843
>             Project: Directory ApacheDS
>          Issue Type: Bug
>    Affects Versions: 1.0.1, 1.5.0
>            Reporter: Emmanuel Lecharny
>             Fix For: 1.0.1, 1.5.0
>
>
> If we try to normalize a DN which is not an instance of String, Name or LdapDN? we might get a NPE. 
> We should throw an exception instead of allowing such NPE.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (DIRSERVER-843) NPE in DnNormalizer

Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DIRSERVER-843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Emmanuel Lecharny closed DIRSERVER-843.
---------------------------------------


Fixed and tested

> NPE in DnNormalizer
> -------------------
>
>                 Key: DIRSERVER-843
>                 URL: https://issues.apache.org/jira/browse/DIRSERVER-843
>             Project: Directory ApacheDS
>          Issue Type: Bug
>    Affects Versions: 1.0.1, 1.5.0
>            Reporter: Emmanuel Lecharny
>             Fix For: 1.0.1, 1.5.0
>
>
> If we try to normalize a DN which is not an instance of String, Name or LdapDN? we might get a NPE. 
> We should throw an exception instead of allowing such NPE.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DIRSERVER-843) NPE in DnNormalizer

Posted by "Stephane Bailliez (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DIRSERVER-843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12477763 ] 

Stephane Bailliez commented on DIRSERVER-843:
---------------------------------------------

Might be better to actually give the class/value you were trying to normalize, otherwise it may not be extremely helpful


> NPE in DnNormalizer
> -------------------
>
>                 Key: DIRSERVER-843
>                 URL: https://issues.apache.org/jira/browse/DIRSERVER-843
>             Project: Directory ApacheDS
>          Issue Type: Bug
>    Affects Versions: 1.0.1, 1.5.0
>            Reporter: Emmanuel Lecharny
>             Fix For: 1.0.1, 1.5.0
>
>
> If we try to normalize a DN which is not an instance of String, Name or LdapDN? we might get a NPE. 
> We should throw an exception instead of allowing such NPE.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DIRSERVER-843) NPE in DnNormalizer

Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DIRSERVER-843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12477766 ] 

Emmanuel Lecharny commented on DIRSERVER-843:
---------------------------------------------

>From an end user perspective, yes, but this class is only used inside ApacheDS, and our problem is that it might me called with any kind of object (when we expect String, LdapDN or Name). We only need to throw an exception which will be catched at an upper level and transformed to a valid Ldap error message (a NPE won't be catched).

However, even the exception seems to be a little bit too much. We might simply :
- create three methods, for each possible parameter (atm, we use instanceof ...)
- or simply use one single method which accept a String and nothing else

The API is not very consistant, at least ...

> NPE in DnNormalizer
> -------------------
>
>                 Key: DIRSERVER-843
>                 URL: https://issues.apache.org/jira/browse/DIRSERVER-843
>             Project: Directory ApacheDS
>          Issue Type: Bug
>    Affects Versions: 1.0.1, 1.5.0
>            Reporter: Emmanuel Lecharny
>             Fix For: 1.0.1, 1.5.0
>
>
> If we try to normalize a DN which is not an instance of String, Name or LdapDN? we might get a NPE. 
> We should throw an exception instead of allowing such NPE.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DIRSERVER-843) NPE in DnNormalizer

Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DIRSERVER-843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12470984 ] 

Emmanuel Lecharny commented on DIRSERVER-843:
---------------------------------------------

Fixed in 1.0.1 :
http://svn.apache.org/viewvc?view=rev&rev=504563

> NPE in DnNormalizer
> -------------------
>
>                 Key: DIRSERVER-843
>                 URL: https://issues.apache.org/jira/browse/DIRSERVER-843
>             Project: Directory ApacheDS
>          Issue Type: Bug
>    Affects Versions: 1.0.1, 1.5.0
>            Reporter: Emmanuel Lecharny
>             Fix For: 1.0.1, 1.5.0
>
>
> If we try to normalize a DN which is not an instance of String, Name or LdapDN? we might get a NPE. 
> We should throw an exception instead of allowing such NPE.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DIRSERVER-843) NPE in DnNormalizer

Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DIRSERVER-843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Emmanuel Lecharny updated DIRSERVER-843:
----------------------------------------

        Fix Version/s: 1.5.0
                       1.0.1
    Affects Version/s: 1.5.0
                       1.0.1

> NPE in DnNormalizer
> -------------------
>
>                 Key: DIRSERVER-843
>                 URL: https://issues.apache.org/jira/browse/DIRSERVER-843
>             Project: Directory ApacheDS
>          Issue Type: Bug
>    Affects Versions: 1.0.1, 1.5.0
>            Reporter: Emmanuel Lecharny
>             Fix For: 1.0.1, 1.5.0
>
>
> If we try to normalize a DN which is not an instance of String, Name or LdapDN? we might get a NPE. 
> We should throw an exception instead of allowing such NPE.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.