You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Baike Xia (Code Review)" <ge...@cloudera.org> on 2023/08/04 06:45:32 UTC
[Impala-ASF-CR] IMPALA-11898: Add query options in the profile even if the query failed in planning
Baike Xia has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/19517 )
Change subject: IMPALA-11898: Add query options in the profile even if the query failed in planning
......................................................................
IMPALA-11898: Add query options in the profile even if the query failed in planning
Currently, query options are added to profile in
ClientRequestState::Exec() which is not executed if the query failed
in planning or not admitted
(e.g. timeout in queueing or cancelled before execution).
This patch moves the logics to where the query options are ready
to be added. To be specifit, "Query Options (set by configuration)"
is there when the client submits the request, so we add it in the
constructor of ClientRequestState.
"Query Options (set by configuration and planner)" is ready
when planning finishes.
So it's moved to right after the call of RunFrontendPlanner().
Change-Id: I0e9ce62008dd5b1671b09eda5365cbb0940ebe64
---
M be/src/runtime/query-driver.cc
M be/src/service/client-request-state.cc
M be/src/service/impala-server.cc
M tests/query_test/test_observability.py
4 files changed, 23 insertions(+), 13 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/17/19517/6
--
To view, visit http://gerrit.cloudera.org:8080/19517
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0e9ce62008dd5b1671b09eda5365cbb0940ebe64
Gerrit-Change-Number: 19517
Gerrit-PatchSet: 6
Gerrit-Owner: Baike Xia <xi...@163.com>
Gerrit-Reviewer: Baike Xia <xi...@163.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>