You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2022/05/10 03:26:04 UTC
[GitHub] [geode-native] moleske opened a new pull request, #968: GEODE-10291: Add ubuntu 22.04 (jammy) to CI
moleske opened a new pull request, #968:
URL: https://github.com/apache/geode-native/pull/968
I don't have ami credentials nor concourse credentials to test any of this, so I will need some help if this should be wanted in CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode-native] gaussianrecurrence commented on a diff in pull request #968: GEODE-10291: Add ubuntu 22.04 (jammy) to CI
Posted by GitBox <gi...@apache.org>.
gaussianrecurrence commented on code in PR #968:
URL: https://github.com/apache/geode-native/pull/968#discussion_r971864236
##########
docker/ubuntu-22.04/Dockerfile:
##########
@@ -0,0 +1,67 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+FROM ubuntu:22.04
+LABEL maintainer Apache Geode <de...@geode.apache.org>
+
+USER root
+WORKDIR /
+
+ENV DEBIAN_FRONTEND noninteractive
+RUN apt update && \
+ apt -yq full-upgrade && \
+ apt-get -y install \
+ apt-transport-https \
+ ca-certificates \
+ curl \
+ gnupg2 \
+ software-properties-common && \
+ apt-get -y autoremove && \
+ apt-get autoclean
+
+RUN . /etc/os-release && \
+ curl -s https://download.bell-sw.com/pki/GPG-KEY-bellsoft | apt-key add - && \
+ apt-add-repository "deb http://apt.bell-sw.com/ stable main"
+
+RUN apt update && apt -yq full-upgrade && apt-get -y install \
+ build-essential \
+ libc++-dev \
+ libc++abi-dev \
+ zlib1g-dev \
+ libssl-dev \
+ bellsoft-java11 \
+ git \
+ doxygen \
+ graphviz \
+ clang-format-12 && \
+ apt-get -y autoremove && \
+ apt-get autoclean
+
+# Get latest release of CMake ignoring pre-releases
+RUN installer=$(mktemp) \
+ && curl -o ${installer} -L $(curl -s https://api.github.com/repos/Kitware/CMake/releases \
+ | grep -P -i 'browser_download_url.*cmake-\d+\.\d+\.\d+-linux-x86_64\.sh' \
+ | head -n 1 \
+ | cut -d : -f 2,3 \
+ | tr -d '"') \
+ && bash ${installer} --skip-license --prefix=/usr/local \
+ && rm ${installer}
+
+ARG GEODE_VERSION=1.14.4
Review Comment:
Considering latest version is 1.15.0, maybe this needs to be updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode-native] moleske commented on a diff in pull request #968: GEODE-10291: Add ubuntu 22.04 (jammy) to CI
Posted by GitBox <gi...@apache.org>.
moleske commented on code in PR #968:
URL: https://github.com/apache/geode-native/pull/968#discussion_r869449791
##########
docker/ubuntu-22.04/Dockerfile:
##########
@@ -0,0 +1,71 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+FROM ubuntu:22.04
+LABEL maintainer Apache Geode <de...@geode.apache.org>
+
+USER root
+WORKDIR /
+
+ENV DEBIAN_FRONTEND noninteractive
+RUN apt update && \
+ apt -yq full-upgrade && \
+ apt-get -y install \
+ apt-transport-https \
+ ca-certificates \
+ curl \
+ gnupg2 \
+ software-properties-common && \
+ apt-get -y autoremove && \
+ apt-get autoclean
+
+RUN . /etc/os-release && \
+ curl -s https://download.bell-sw.com/pki/GPG-KEY-bellsoft | apt-key add - && \
+ apt-add-repository "deb http://apt.bell-sw.com/ stable main"
+
+RUN apt update && apt -yq full-upgrade && apt-get -y install \
+ build-essential \
+ libc++-dev \
+ libc++abi-dev \
+ zlib1g-dev \
+ libssl-dev \
+ bellsoft-java11 \
+ git \
+ doxygen \
+ graphviz \
+ python3-pip \
+ clang-format-6.0 && \
Review Comment:
lol. I just copied pasted the ubuntu-20.04 dockerfile, so I didn't actually look at anything beyond the from line. I'll clean these up.
Also I don't think these are used in ci after another look, they are only here for convenience. Not sure if anyone cares, just an observation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode-native] gaussianrecurrence commented on pull request #968: GEODE-10291: Add ubuntu 22.04 (jammy) to CI
Posted by GitBox <gi...@apache.org>.
gaussianrecurrence commented on PR #968:
URL: https://github.com/apache/geode-native/pull/968#issuecomment-1265076566
Hi @moleske & @pivotal-jbarrett, it seems to me that @moleke addressed all the comments, so I am not sure is this can be merged already?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GEODE-10291: Add ubuntu 22.04 (jammy) to CI [geode-native]
Posted by "moleske (via GitHub)" <gi...@apache.org>.
moleske closed pull request #968: GEODE-10291: Add ubuntu 22.04 (jammy) to CI
URL: https://github.com/apache/geode-native/pull/968
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode-native] pivotal-jbarrett commented on a diff in pull request #968: GEODE-10291: Add ubuntu 22.04 (jammy) to CI
Posted by GitBox <gi...@apache.org>.
pivotal-jbarrett commented on code in PR #968:
URL: https://github.com/apache/geode-native/pull/968#discussion_r869462212
##########
docker/ubuntu-22.04/Dockerfile:
##########
@@ -0,0 +1,71 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+FROM ubuntu:22.04
+LABEL maintainer Apache Geode <de...@geode.apache.org>
+
+USER root
+WORKDIR /
+
+ENV DEBIAN_FRONTEND noninteractive
+RUN apt update && \
+ apt -yq full-upgrade && \
+ apt-get -y install \
+ apt-transport-https \
+ ca-certificates \
+ curl \
+ gnupg2 \
+ software-properties-common && \
+ apt-get -y autoremove && \
+ apt-get autoclean
+
+RUN . /etc/os-release && \
+ curl -s https://download.bell-sw.com/pki/GPG-KEY-bellsoft | apt-key add - && \
+ apt-add-repository "deb http://apt.bell-sw.com/ stable main"
+
+RUN apt update && apt -yq full-upgrade && apt-get -y install \
+ build-essential \
+ libc++-dev \
+ libc++abi-dev \
+ zlib1g-dev \
+ libssl-dev \
+ bellsoft-java11 \
+ git \
+ doxygen \
+ graphviz \
+ python3-pip \
+ clang-format-6.0 && \
Review Comment:
Not used by CI. I occasionally use them locally to compile under the alternative platforms when trying to debug a platform specific issue. They get very little love.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode-native] moleske commented on a diff in pull request #968: GEODE-10291: Add ubuntu 22.04 (jammy) to CI
Posted by GitBox <gi...@apache.org>.
moleske commented on code in PR #968:
URL: https://github.com/apache/geode-native/pull/968#discussion_r972202959
##########
docker/ubuntu-22.04/Dockerfile:
##########
@@ -0,0 +1,67 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+FROM ubuntu:22.04
+LABEL maintainer Apache Geode <de...@geode.apache.org>
+
+USER root
+WORKDIR /
+
+ENV DEBIAN_FRONTEND noninteractive
+RUN apt update && \
+ apt -yq full-upgrade && \
+ apt-get -y install \
+ apt-transport-https \
+ ca-certificates \
+ curl \
+ gnupg2 \
+ software-properties-common && \
+ apt-get -y autoremove && \
+ apt-get autoclean
+
+RUN . /etc/os-release && \
+ curl -s https://download.bell-sw.com/pki/GPG-KEY-bellsoft | apt-key add - && \
+ apt-add-repository "deb http://apt.bell-sw.com/ stable main"
+
+RUN apt update && apt -yq full-upgrade && apt-get -y install \
+ build-essential \
+ libc++-dev \
+ libc++abi-dev \
+ zlib1g-dev \
+ libssl-dev \
+ bellsoft-java11 \
+ git \
+ doxygen \
+ graphviz \
+ clang-format-12 && \
+ apt-get -y autoremove && \
+ apt-get autoclean
+
+# Get latest release of CMake ignoring pre-releases
+RUN installer=$(mktemp) \
+ && curl -o ${installer} -L $(curl -s https://api.github.com/repos/Kitware/CMake/releases \
+ | grep -P -i 'browser_download_url.*cmake-\d+\.\d+\.\d+-linux-x86_64\.sh' \
+ | head -n 1 \
+ | cut -d : -f 2,3 \
+ | tr -d '"') \
+ && bash ${installer} --skip-license --prefix=/usr/local \
+ && rm ${installer}
+
+ARG GEODE_VERSION=1.14.4
Review Comment:
ah joys of forgetting about prs for months on end, can bump it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode-native] pivotal-jbarrett commented on a diff in pull request #968: GEODE-10291: Add ubuntu 22.04 (jammy) to CI
Posted by GitBox <gi...@apache.org>.
pivotal-jbarrett commented on code in PR #968:
URL: https://github.com/apache/geode-native/pull/968#discussion_r869424555
##########
docker/ubuntu-22.04/Dockerfile:
##########
@@ -0,0 +1,71 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+FROM ubuntu:22.04
+LABEL maintainer Apache Geode <de...@geode.apache.org>
+
+USER root
+WORKDIR /
+
+ENV DEBIAN_FRONTEND noninteractive
+RUN apt update && \
+ apt -yq full-upgrade && \
+ apt-get -y install \
+ apt-transport-https \
+ ca-certificates \
+ curl \
+ gnupg2 \
+ software-properties-common && \
+ apt-get -y autoremove && \
+ apt-get autoclean
+
+RUN . /etc/os-release && \
+ curl -s https://download.bell-sw.com/pki/GPG-KEY-bellsoft | apt-key add - && \
+ apt-add-repository "deb http://apt.bell-sw.com/ stable main"
+
+RUN apt update && apt -yq full-upgrade && apt-get -y install \
+ build-essential \
+ libc++-dev \
+ libc++abi-dev \
+ zlib1g-dev \
+ libssl-dev \
+ bellsoft-java11 \
+ git \
+ doxygen \
+ graphviz \
+ python3-pip \
+ clang-format-6.0 && \
+ apt-get -y autoremove && \
+ apt-get autoclean
+
+RUN pip3 install --upgrade pip && \
Review Comment:
I think you can cut out the coveralls bits. We haven't really been using it. Then you can cut out pip above too.
##########
docker/ubuntu-22.04/Dockerfile:
##########
@@ -0,0 +1,71 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+FROM ubuntu:22.04
+LABEL maintainer Apache Geode <de...@geode.apache.org>
+
+USER root
+WORKDIR /
+
+ENV DEBIAN_FRONTEND noninteractive
+RUN apt update && \
+ apt -yq full-upgrade && \
+ apt-get -y install \
+ apt-transport-https \
+ ca-certificates \
+ curl \
+ gnupg2 \
+ software-properties-common && \
+ apt-get -y autoremove && \
+ apt-get autoclean
+
+RUN . /etc/os-release && \
+ curl -s https://download.bell-sw.com/pki/GPG-KEY-bellsoft | apt-key add - && \
+ apt-add-repository "deb http://apt.bell-sw.com/ stable main"
+
+RUN apt update && apt -yq full-upgrade && apt-get -y install \
+ build-essential \
+ libc++-dev \
+ libc++abi-dev \
+ zlib1g-dev \
+ libssl-dev \
+ bellsoft-java11 \
+ git \
+ doxygen \
+ graphviz \
+ python3-pip \
+ clang-format-6.0 && \
Review Comment:
Gosh, this should probably be clang-format-11.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode-native] moleske commented on a diff in pull request #968: GEODE-10291: Add ubuntu 22.04 (jammy) to CI
Posted by GitBox <gi...@apache.org>.
moleske commented on code in PR #968:
URL: https://github.com/apache/geode-native/pull/968#discussion_r871899747
##########
docker/ubuntu-22.04/Dockerfile:
##########
@@ -0,0 +1,71 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+FROM ubuntu:22.04
+LABEL maintainer Apache Geode <de...@geode.apache.org>
+
+USER root
+WORKDIR /
+
+ENV DEBIAN_FRONTEND noninteractive
+RUN apt update && \
+ apt -yq full-upgrade && \
+ apt-get -y install \
+ apt-transport-https \
+ ca-certificates \
+ curl \
+ gnupg2 \
+ software-properties-common && \
+ apt-get -y autoremove && \
+ apt-get autoclean
+
+RUN . /etc/os-release && \
+ curl -s https://download.bell-sw.com/pki/GPG-KEY-bellsoft | apt-key add - && \
+ apt-add-repository "deb http://apt.bell-sw.com/ stable main"
+
+RUN apt update && apt -yq full-upgrade && apt-get -y install \
+ build-essential \
+ libc++-dev \
+ libc++abi-dev \
+ zlib1g-dev \
+ libssl-dev \
+ bellsoft-java11 \
+ git \
+ doxygen \
+ graphviz \
+ python3-pip \
+ clang-format-6.0 && \
Review Comment:
per some outside of here conversation with @pdxcodemonkey it is clang-format-12. There's a lot of inconsistency in the other dockerfiles, and clang-format-12 is not in the default repository for ubuntu 16.04 and 18.04, so will only fix it for ubuntu 22.04 for now and pr the other dockerfiles later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org