[GitHub] [spark] caican00 commented on a diff in pull request #42003: [SPARK-44426][SQL] Optimize adaptive skew join for ExistenceJoin

["caican00 (via GitHub)" <gi...@apache.org>]

caican00 commented on code in PR #42003:
URL: https://github.com/apache/spark/pull/42003#discussion_r1271294044


##########
sql/core/src/test/scala/org/apache/spark/sql/execution/adaptive/AdaptiveQueryExecSuite.scala:
##########
@@ -874,6 +875,96 @@ class AdaptiveQueryExecSuite
     }
   }
 
+  test("SPARK-44426: Optimize adaptive skew join for ExistenceJoin") {
+    withSQLConf(
+      SQLConf.AUTO_BROADCASTJOIN_THRESHOLD.key -> "-1",
+      SQLConf.COALESCE_PARTITIONS_MIN_PARTITION_NUM.key -> "1",
+      SQLConf.SHUFFLE_PARTITIONS.key -> "100",
+      SQLConf.SKEW_JOIN_SKEWED_PARTITION_THRESHOLD.key -> "800",
+      SQLConf.ADVISORY_PARTITION_SIZE_IN_BYTES.key -> "800") {
+      withTempView("skewData1", "skewData2", "skewData3", "skewData4") {

Review Comment:
   > Can we simplify and clear the test a bit? We can make tests using one join that one side is a skewed table and other side is not. Then we can switch it's side to verify what happens if the skewed side is on left or right.
   
   @ulysses-you Have been modified. Thanks for reviewing



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org