You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/10/13 14:56:02 UTC

[GitHub] [flink-kubernetes-operator] morhidi opened a new pull request, #401: [FLINK-29619] Remove redundant MeterView updater thread from KubernetesClientMetrics

morhidi opened a new pull request, #401:
URL: https://github.com/apache/flink-kubernetes-operator/pull/401

   ## What is the purpose of the change
   
   The `KubernetesClientMetrics` class has a redundant background thread that periodically updates the `MeterView` metrics. However the `MetricRegistryImpl` already has a built in solution for this.
   
   ## Brief change log
     - Removed the periodic updater from `KubernetesClientMetrics`
     - Updated the `TestingMetricListener` to follow the logic implemented in `MetricRegistryImpl`
     - Updated the `KubernetesClientMetricsTest` to use the `TestingMetricListener`
   ## Verifying this change
     - Covered by existing unit tests
     - Verified manually
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changes to the `CustomResourceDescriptors`: no
     - Core observer or reconciler logic that is regularly executed: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink-kubernetes-operator] gyfora merged pull request #401: [FLINK-29619] Remove redundant MeterView updater thread from KubernetesClientMetrics

Posted by GitBox <gi...@apache.org>.
gyfora merged PR #401:
URL: https://github.com/apache/flink-kubernetes-operator/pull/401


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org