You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2025/06/06 18:51:03 UTC
[PR] Improve coalesce_kernel benchmark [arrow-rs]
alamb opened a new pull request, #7619:
URL: https://github.com/apache/arrow-rs/pull/7619
# Which issue does this PR close?
- Follow on to https://github.com/apache/arrow-rs/pull/7597
# Rationale for this change
While reviewing the code and the concat kernel for
- https://github.com/apache/arrow-rs/pull/7617
I realized there is a non trivial difference when there all inlined views vs some inlined views vs mostly large strings so the benchmarks should capture that
# What changes are included in this PR?
1. Add variations of benchmark with different size strings in StringViewArray
# Are there any user-facing changes?
If there are user-facing changes then we may require documentation to be updated before approving the PR.
If there are any breaking changes to public APIs, please call them out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve coalesce_kernel benchmark to capture inline vs non inline views [arrow-rs]
Posted by "Dandandan (via GitHub)" <gi...@apache.org>.
Dandandan merged PR #7619:
URL: https://github.com/apache/arrow-rs/pull/7619
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve coalesce_kernel benchmark [arrow-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #7619:
URL: https://github.com/apache/arrow-rs/pull/7619#discussion_r2132715898
##########
arrow/benches/coalesce_kernels.rs:
##########
@@ -77,17 +77,33 @@ fn add_all_filter_benchmarks(c: &mut Criterion) {
num_output_batches: 50,
null_density,
selectivity,
+ max_string_len: 30,
schema: &single_schema,
}
.build();
+ // Model mostly short strings, but some longer ones
Review Comment:
Previously all the benchmarks used a max size of 30. Now I have 20 (12/20 = 60% will be inlined views) and 128 where only 12/128 ~ 1% will be inlined views.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org