You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@teaclave.apache.org by Michael Quinlan <no...@github.com.INVALID> on 2020/10/16 18:44:07 UTC
[apache/incubator-teaclave-sgx-sdk] Added conditional compilation for
musl targets (#273)
Allows building statically linked applications. This is useful for organizations needing to extend backwards compatibility to older OS releases.
You can view, comment on, or merge this pull request online at:
https://github.com/apache/incubator-teaclave-sgx-sdk/pull/273
-- Commit Summary --
* Added conditional compilation for musl targets
-- File Changes --
M sgx_urts/src/fd.rs (39)
-- Patch Links --
https://github.com/apache/incubator-teaclave-sgx-sdk/pull/273.patch
https://github.com/apache/incubator-teaclave-sgx-sdk/pull/273.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave-sgx-sdk/pull/273
Re: [apache/incubator-teaclave-sgx-sdk] Added conditional compilation
for musl targets (#273)
Posted by Mingshen Sun <no...@github.com.INVALID>.
Looks good to me. I think this can be documented somewhere so that other people may also interested.
@dingelish, what do you think.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave-sgx-sdk/pull/273#issuecomment-710415285
Re: [apache/incubator-teaclave-sgx-sdk] Added conditional compilation
for musl targets (#273)
Posted by Michael Quinlan <no...@github.com.INVALID>.
Thanks! Let me add some documentation in a second commit.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave-sgx-sdk/pull/273#issuecomment-710429444
Re: [apache/incubator-teaclave-sgx-sdk] Added conditional compilation
for musl targets (#273)
Posted by Mingshen Sun <no...@github.com.INVALID>.
@mjquinlan Thank you so much! I'm wondering if there's any update on this PR.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave-sgx-sdk/pull/273#issuecomment-918550411
Re: [apache/incubator-teaclave-sgx-sdk] Added conditional compilation
for musl targets (#273)
Posted by Yu Ding <no...@github.com.INVALID>.
sgtm :-) better if comes along with some description by either code comments or readme.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave-sgx-sdk/pull/273#issuecomment-710422202