You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2022/11/29 08:00:16 UTC
[GitHub] [incubator-eventmesh] jonyangx opened a new pull request, #2307: [ISSUE #2306] fix common module pmd test error
jonyangx opened a new pull request, #2307:
URL: https://github.com/apache/incubator-eventmesh/pull/2307
Fixes #2306 .
### Motivation
fix common module pmd test error
### Modifications
fix common module pmd test error
### Documentation
- Does this pull request introduce a new feature? ( no)
- If yes, how is the feature documented? ( not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] codecov[bot] commented on pull request #2307: [ISSUE #2306] fix common module pmd test error
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #2307:
URL: https://github.com/apache/incubator-eventmesh/pull/2307#issuecomment-1330438941
# [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/2307?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2307](https://codecov.io/gh/apache/incubator-eventmesh/pull/2307?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8d6afba) into [master](https://codecov.io/gh/apache/incubator-eventmesh/commit/34b732b4bd963683540856826f26b76883588251?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (34b732b) will **decrease** coverage by `0.09%`.
> The diff coverage is `19.84%`.
```diff
@@ Coverage Diff @@
## master #2307 +/- ##
============================================
- Coverage 11.74% 11.65% -0.10%
+ Complexity 897 894 -3
============================================
Files 468 465 -3
Lines 27835 27803 -32
Branches 3008 3004 -4
============================================
- Hits 3270 3241 -29
Misses 24265 24265
+ Partials 300 297 -3
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-eventmesh/pull/2307?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...eventmesh/common/exception/EventMeshException.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/2307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9leGNlcHRpb24vRXZlbnRNZXNoRXhjZXB0aW9uLmphdmE=) | `0.00% <ø> (ø)` | |
| [...ache/eventmesh/common/exception/JsonException.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/2307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9leGNlcHRpb24vSnNvbkV4Y2VwdGlvbi5qYXZh) | `0.00% <ø> (ø)` | |
| [...apache/eventmesh/common/file/WatchFileManager.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/2307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9maWxlL1dhdGNoRmlsZU1hbmFnZXIuamF2YQ==) | `58.33% <0.00%> (-9.32%)` | :arrow_down: |
| [...he/eventmesh/common/protocol/SubscriptionItem.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/2307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC9TdWJzY3JpcHRpb25JdGVtLmphdmE=) | `0.00% <ø> (ø)` | |
| [...mmon/protocol/grpc/common/BatchMessageWrapper.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/2307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC9ncnBjL2NvbW1vbi9CYXRjaE1lc3NhZ2VXcmFwcGVyLmphdmE=) | `0.00% <ø> (ø)` | |
| [...mon/protocol/grpc/common/SimpleMessageWrapper.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/2307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC9ncnBjL2NvbW1vbi9TaW1wbGVNZXNzYWdlV3JhcHBlci5qYXZh) | `0.00% <ø> (ø)` | |
| [...he/eventmesh/common/protocol/http/HttpCommand.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/2307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC9odHRwL0h0dHBDb21tYW5kLmphdmE=) | `60.00% <ø> (ø)` | |
| [...entmesh/common/protocol/http/HttpEventWrapper.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/2307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC9odHRwL0h0dHBFdmVudFdyYXBwZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...ocol/http/body/message/PushMessageRequestBody.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/2307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC9odHRwL2JvZHkvbWVzc2FnZS9QdXNoTWVzc2FnZVJlcXVlc3RCb2R5LmphdmE=) | `0.00% <ø> (ø)` | |
| [...col/http/body/message/ReplyMessageRequestBody.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/2307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC9odHRwL2JvZHkvbWVzc2FnZS9SZXBseU1lc3NhZ2VSZXF1ZXN0Qm9keS5qYXZh) | `0.00% <ø> (ø)` | |
| ... and [96 more](https://codecov.io/gh/apache/incubator-eventmesh/pull/2307/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] xwm1992 commented on pull request #2307: [ISSUE #2306] fix common module pmd test error
Posted by GitBox <gi...@apache.org>.
xwm1992 commented on PR #2307:
URL: https://github.com/apache/incubator-eventmesh/pull/2307#issuecomment-1335004783
Theses commits are too much seems the branch is under the wrong status. @jonyangx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] horoc commented on pull request #2307: [ISSUE #2306] fix common module pmd test error
Posted by GitBox <gi...@apache.org>.
horoc commented on PR #2307:
URL: https://github.com/apache/incubator-eventmesh/pull/2307#issuecomment-1330631628
I think it's better to split those changes into smaller PR since there are hundreds of file changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] jonyangx closed pull request #2307: [ISSUE #2306] fix common module pmd test error
Posted by GitBox <gi...@apache.org>.
jonyangx closed pull request #2307: [ISSUE #2306] fix common module pmd test error
URL: https://github.com/apache/incubator-eventmesh/pull/2307
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org