You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by ch...@apache.org on 2023/03/17 04:31:46 UTC
[kyuubi] branch master updated: [KYUUBI #4546] Fully exclude `metrics` dir from git
This is an automated email from the ASF dual-hosted git repository.
chengpan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kyuubi.git
The following commit(s) were added to refs/heads/master by this push:
new 4d67dac43 [KYUUBI #4546] Fully exclude `metrics` dir from git
4d67dac43 is described below
commit 4d67dac437a5358b816eb7d0d926ec259c2fbb6f
Author: zwangsheng <22...@qq.com>
AuthorDate: Fri Mar 17 12:31:36 2023 +0800
[KYUUBI #4546] Fully exclude `metrics` dir from git
### _Why are the changes needed?_
Follow our attitude towards other excluded folders, exclude the entire `metrics` folder.
Like in `.gitignore`
```
embedded_zookeeper/
```
`metrics` dir will be created in source code when run `KyuubiServer` in local IDE.
Close #4546
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ ] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request
Closes #4547 from zwangsheng/KYUUBI_4546.
Closes #4546
8f13670e6 [zwangsheng] [KYUUBI #4546] Ignore full metrics dir in git version control
Authored-by: zwangsheng <22...@qq.com>
Signed-off-by: Cheng Pan <ch...@apache.org>
---
.gitignore | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/.gitignore b/.gitignore
index 9a115ab0a..190294d06 100644
--- a/.gitignore
+++ b/.gitignore
@@ -58,8 +58,7 @@ metastore_db
derby.log
rest-audit.log
**/dependency-reduced-pom.xml
-metrics/report.json
-metrics/.report.json.crc
+metrics/
/kyuubi-ha/embedded_zookeeper/
embedded_zookeeper/
/externals/kyuubi-spark-sql-engine/operation_logs/