You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/05/28 14:40:41 UTC
[GitHub] [nifi] pgyori opened a new pull request #4303: NIFI-7312: Enable search in variable registry of root process group
pgyori opened a new pull request #4303:
URL: https://github.com/apache/nifi/pull/4303
https://issues.apache.org/jira/browse/NIFI-7312
#### Description of PR
Enables search in variable registry of root process group.
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `master`)?
- [ ] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] Have you verified that the full build is successful on JDK 8?
- [ ] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] markap14 commented on pull request #4303: NIFI-7312: Enable search in variable registry of root process group
Posted by GitBox <gi...@apache.org>.
markap14 commented on pull request #4303:
URL: https://github.com/apache/nifi/pull/4303#issuecomment-637695051
Thanks @pgyori for the fix, and thanks for reviewing @tpalfy! I concur with your LGTM+1. Merged to master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] markap14 closed pull request #4303: NIFI-7312: Enable search in variable registry of root process group
Posted by GitBox <gi...@apache.org>.
markap14 closed pull request #4303:
URL: https://github.com/apache/nifi/pull/4303
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] simonbence commented on a change in pull request #4303: NIFI-7312: Enable search in variable registry of root process group
Posted by GitBox <gi...@apache.org>.
simonbence commented on a change in pull request #4303:
URL: https://github.com/apache/nifi/pull/4303#discussion_r432322027
##########
File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/test/java/org/apache/nifi/web/controller/ControllerSearchServiceTest.java
##########
@@ -191,6 +185,7 @@ public void testSearchWhenGroupIsNotAuthorized() {
testSubject.search(searchQuery, results);
// The authorization is not transitive, children groups might be good candidates.
thenFollowingGroupsAreSearched(Arrays.asList(
+ PROCESS_GROUP_ROOT,
Review comment:
This looks a little strange to my be retrospect, but the documentation says “To reduce the amount of time admins spend on authorization management, policies are inherited from parent resource to child resource”, so I think in practice the case where you cannot access the process group but you can access a resource within should not happen.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] pgyori commented on a change in pull request #4303: NIFI-7312: Enable search in variable registry of root process group
Posted by GitBox <gi...@apache.org>.
pgyori commented on a change in pull request #4303:
URL: https://github.com/apache/nifi/pull/4303#discussion_r432657239
##########
File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/test/java/org/apache/nifi/web/controller/ControllerSearchServiceRegressionTest.java
##########
@@ -265,6 +265,13 @@ public void testTextOmniMatch() {
"Variable Value: processgroup1_variable2_value_omniMatch"
);
+ final ComponentSearchResultDTO rootProcessGroupResult = getSimpleResult(ROOT_PROCESSOR_GROUP_ID, ROOT_PROCESSOR_GROUP_NAME,
+ ROOT_PROCESSOR_GROUP_ID,
+ null,
+ null,
+ "Comments: root_no_find_omniMatch"
Review comment:
Thank you @tpalfy ! Fixed it in the next commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] tpalfy commented on a change in pull request #4303: NIFI-7312: Enable search in variable registry of root process group
Posted by GitBox <gi...@apache.org>.
tpalfy commented on a change in pull request #4303:
URL: https://github.com/apache/nifi/pull/4303#discussion_r432535909
##########
File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/test/java/org/apache/nifi/web/controller/ControllerSearchServiceRegressionTest.java
##########
@@ -265,6 +265,13 @@ public void testTextOmniMatch() {
"Variable Value: processgroup1_variable2_value_omniMatch"
);
+ final ComponentSearchResultDTO rootProcessGroupResult = getSimpleResult(ROOT_PROCESSOR_GROUP_ID, ROOT_PROCESSOR_GROUP_NAME,
+ ROOT_PROCESSOR_GROUP_ID,
+ null,
+ null,
+ "Comments: root_no_find_omniMatch"
Review comment:
The idea was that it's called "...no_find..." because even though it contains the search keyword ("omniMatch") according to the business logic, it shouldn't be found.
Now that this logic has been changed and we _do_ search in the root process group comments (among others) we might want to change it to `"root_comments_omnitMatch"`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org