You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2022/04/27 02:26:50 UTC

[GitHub] [bookkeeper] hangc0276 commented on a diff in pull request #3197: BP-47 (task3): Abstract interface for entrylogger

hangc0276 commented on code in PR #3197:
URL: https://github.com/apache/bookkeeper/pull/3197#discussion_r859320293


##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/SortedLedgerStorage.java:
##########
@@ -260,7 +261,8 @@ public void cancelWaitForLastAddConfirmedUpdate(long ledgerId,
     @Override
     public void checkpoint(final Checkpoint checkpoint) throws IOException {
         long numBytesFlushed = memTable.flush(this, checkpoint);
-        interleavedLedgerStorage.getEntryLogger().prepareSortedLedgerStorageCheckpoint(numBytesFlushed);
+        ((DefaultEntryLogger) interleavedLedgerStorage.getEntryLogger())

Review Comment:
   We are using `DefaultEntryLogger` to initiate InterleavedLedgerStorage entryLogger instance. So we can convert it into `DefaultEntryLogger` here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org