[jira] Closed: (MNG-5027) Problem executing custom surefire implementation in Maven 3.0.3-RC1

["Benjamin Bentmann (JIRA)" <ji...@codehaus.org>]

     [ http://jira.codehaus.org/browse/MNG-5027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Benjamin Bentmann closed MNG-5027.
----------------------------------

    Resolution: Not A Bug
      Assignee: Benjamin Bentmann

>From the forked sources, [SurefirePlugin.java#588|https://github.com/kabir/jboss-modules-surefire-plugin/blob/master/maven-surefire-plugin/src/main/java/org/apache/maven/plugin/surefire/SurefirePlugin.java#L588]
{code:java}
private List<File> roots;
{code}
and from [SurefirePlugin.java#1377|https://github.com/kabir/jboss-modules-surefire-plugin/blob/master/maven-surefire-plugin/src/main/java/org/apache/maven/plugin/surefire/SurefirePlugin.java#L1377]
{code:java}
for (Iterator it = roots.iterator() ; it.hasNext() ; ) {
    File file = new File((String)it.next());
{code}

This is where the compiler and IDE usually point out some issue with type-safety. The field {{roots}} is declared as {{List<File>}} yet the {{Iterator}} usage assumes {{List<String>}}. The newly added support for generics in MNG-5028 makes this programming error show up now.

Assuming the plugin fork should be compatible with older Maven versions, the field {{roots}} should be declared of type {{List<String>}}.

> Problem executing custom surefire implementation in Maven 3.0.3-RC1
> -------------------------------------------------------------------
>
>                 Key: MNG-5027
>                 URL: http://jira.codehaus.org/browse/MNG-5027
>             Project: Maven 2 & 3
>          Issue Type: Bug
>          Components: Plugins and Lifecycle
>            Reporter: Paul Gier
>            Assignee: Benjamin Bentmann
>         Attachments: build.log
>
>
> There seems to be a regression between Maven 3.0.2 to 3.0.3-RC1.  When executing the jboss-as build [1] the build fails during execution of our custom implementation of the surefire plugin [2].
> [1]https://github.com/jbossas/jboss-as
> [2]http://community.jboss.org/wiki/JBossModulesSurefirePlugin

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira