You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@bookkeeper.apache.org by gi...@git.apache.org on 2017/09/28 17:58:48 UTC

[GitHub] eolivelli commented on a change in pull request #526: ISSUE 525 Refactor PerChannelBookieClient [WIP]

eolivelli commented on a change in pull request #526: ISSUE 525 Refactor PerChannelBookieClient [WIP]
URL: https://github.com/apache/bookkeeper/pull/526#discussion_r141686406
 
 

 ##########
 File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PerChannelBookieClient.java
 ##########
 @@ -654,42 +624,28 @@ public void readEntryAndFenceLedger(final long ledgerId, byte[] masterKey,
         }
 
         final CompletionKey completionKey = completion;
-        if (completionObjects.putIfAbsent(completionKey, new ReadCompletion(this, readEntryOpLogger, cb,
-                ctx, ledgerId, entryId, scheduleTimeout(completionKey, readEntryTimeout))) != null) {
+        if (completionObjects.putIfAbsent(
 
 Review comment:
   I wonder if we can save some allocation using computeIfAbsent...maybe not
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services