You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rave.apache.org by hi...@gmail.com on 2012/04/16 15:25:32 UTC
Review Request: RAVE-532 Bootstrap-enable widget controls
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4735/
-----------------------------------------------------------
Review request for rave.
Summary
-------
RAVE-532
Bootstrap-enable widget controls
Diffs
-----
branches/bootstrap/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/page.jsp 1325784
branches/bootstrap/rave-portal-resources/src/main/webapp/WEB-INF/tags/region_widget.tag 1325784
branches/bootstrap/rave-portal-resources/src/main/webapp/css/default.css 1325784
branches/bootstrap/rave-portal-resources/src/main/webapp/script/rave.js 1325784
branches/bootstrap/rave-portal-resources/src/main/webapp/script/rave_layout.js 1325784
branches/bootstrap/rave-portal-resources/src/test/javascript/raveSpec.js 1325784
Diff: https://reviews.apache.org/r/4735/diff
Testing
-------
Thanks,
hilker.j
Re: Review Request: RAVE-532 Bootstrap-enable widget controls
Posted by Anthony Carlucci <ac...@mitre.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4735/#review6985
-----------------------------------------------------------
Ship it!
Verified <span> tags were changed to <div> where appropriate.
- Anthony
On 2012-04-16 19:57:45, hilker.j wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4735/
> -----------------------------------------------------------
>
> (Updated 2012-04-16 19:57:45)
>
>
> Review request for rave.
>
>
> Summary
> -------
>
> RAVE-532
> Bootstrap-enable widget controls
>
>
> Diffs
> -----
>
> branches/bootstrap/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/page.jsp 1326775
> branches/bootstrap/rave-portal-resources/src/main/webapp/WEB-INF/tags/region_widget.tag 1326772
> branches/bootstrap/rave-portal-resources/src/main/webapp/css/default.css 1326772
> branches/bootstrap/rave-portal-resources/src/main/webapp/script/rave.js 1326772
> branches/bootstrap/rave-portal-resources/src/main/webapp/script/rave_layout.js 1326772
> branches/bootstrap/rave-portal-resources/src/test/javascript/raveSpec.js 1326772
>
> Diff: https://reviews.apache.org/r/4735/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> hilker.j
>
>
Re: Review Request: RAVE-532 Bootstrap-enable widget controls
Posted by hi...@gmail.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4735/
-----------------------------------------------------------
(Updated 2012-04-16 19:57:45.873172)
Review request for rave.
Changes
-------
Update to use div's instead of spans to avoid block elements within inline elements
Summary
-------
RAVE-532
Bootstrap-enable widget controls
Diffs (updated)
-----
branches/bootstrap/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/page.jsp 1326775
branches/bootstrap/rave-portal-resources/src/main/webapp/WEB-INF/tags/region_widget.tag 1326772
branches/bootstrap/rave-portal-resources/src/main/webapp/css/default.css 1326772
branches/bootstrap/rave-portal-resources/src/main/webapp/script/rave.js 1326772
branches/bootstrap/rave-portal-resources/src/main/webapp/script/rave_layout.js 1326772
branches/bootstrap/rave-portal-resources/src/test/javascript/raveSpec.js 1326772
Diff: https://reviews.apache.org/r/4735/diff
Testing
-------
Thanks,
hilker.j
Re: Review Request: RAVE-532 Bootstrap-enable widget controls
Posted by Jasha Joachimsthal <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4735/#review6943
-----------------------------------------------------------
branches/bootstrap/rave-portal-resources/src/main/webapp/WEB-INF/tags/region_widget.tag
<https://reviews.apache.org/r/4735/#comment15488>
a span cannot contain block elements like div or ul. Please use the proper element.
- Jasha
On 2012-04-16 13:25:32, hilker.j wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4735/
> -----------------------------------------------------------
>
> (Updated 2012-04-16 13:25:32)
>
>
> Review request for rave.
>
>
> Summary
> -------
>
> RAVE-532
> Bootstrap-enable widget controls
>
>
> Diffs
> -----
>
> branches/bootstrap/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/page.jsp 1325784
> branches/bootstrap/rave-portal-resources/src/main/webapp/WEB-INF/tags/region_widget.tag 1325784
> branches/bootstrap/rave-portal-resources/src/main/webapp/css/default.css 1325784
> branches/bootstrap/rave-portal-resources/src/main/webapp/script/rave.js 1325784
> branches/bootstrap/rave-portal-resources/src/main/webapp/script/rave_layout.js 1325784
> branches/bootstrap/rave-portal-resources/src/test/javascript/raveSpec.js 1325784
>
> Diff: https://reviews.apache.org/r/4735/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> hilker.j
>
>