You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Ádám Bakai (Code Review)" <ge...@cloudera.org> on 2023/01/09 09:53:53 UTC
[kudu-CR] KUDU-3292 Show non-default flags on WEB UI
Ádám Bakai has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19408
Change subject: KUDU-3292 Show non-default flags on WEB UI
......................................................................
KUDU-3292 Show non-default flags on WEB UI
Change-Id: Iac723646389d20bd5dbac41524d3a495355387ae
---
M src/kudu/server/default_path_handlers.cc
M src/kudu/util/flag_tags-test.cc
M src/kudu/util/flags.cc
M src/kudu/util/flags.h
4 files changed, 42 insertions(+), 23 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/08/19408/1
--
To view, visit http://gerrit.cloudera.org:8080/19408
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iac723646389d20bd5dbac41524d3a495355387ae
Gerrit-Change-Number: 19408
Gerrit-PatchSet: 1
Gerrit-Owner: Ádám Bakai <ab...@cloudera.com>
[kudu-CR] KUDU-3292 Show non-default flags on WEB UI
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19408 )
Change subject: KUDU-3292 Show non-default flags on WEB UI
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19408
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iac723646389d20bd5dbac41524d3a495355387ae
Gerrit-Change-Number: 19408
Gerrit-PatchSet: 3
Gerrit-Owner: Ádám Bakai <ab...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Tue, 10 Jan 2023 19:25:44 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3292 Show non-default flags on WEB UI
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19408 )
Change subject: KUDU-3292 Show non-default flags on WEB UI
......................................................................
Patch Set 4:
Sorry I didn't reply in the gerrit, but I replied in the jira, could you take a look at it? http://issues.apache.org/jira/browse/KUDU-3292
--
To view, visit http://gerrit.cloudera.org:8080/19408
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iac723646389d20bd5dbac41524d3a495355387ae
Gerrit-Change-Number: 19408
Gerrit-PatchSet: 4
Gerrit-Owner: Ádám Bakai <ab...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Tue, 10 Jan 2023 23:44:04 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3292 Show non-default flags on WEB UI
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19408 )
Change subject: KUDU-3292 Show non-default flags on WEB UI
......................................................................
KUDU-3292 Show non-default flags on WEB UI
Change-Id: Iac723646389d20bd5dbac41524d3a495355387ae
Reviewed-on: http://gerrit.cloudera.org:8080/19408
Tested-by: Kudu Jenkins
Reviewed-by: Zoltan Chovan <zc...@cloudera.com>
Reviewed-by: Alexey Serbin <al...@apache.org>
---
M src/kudu/server/default_path_handlers.cc
M src/kudu/util/flag_tags-test.cc
M src/kudu/util/flags.cc
M src/kudu/util/flags.h
4 files changed, 40 insertions(+), 23 deletions(-)
Approvals:
Kudu Jenkins: Verified
Zoltan Chovan: Looks good to me, but someone else must approve
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/19408
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iac723646389d20bd5dbac41524d3a495355387ae
Gerrit-Change-Number: 19408
Gerrit-PatchSet: 4
Gerrit-Owner: Ádám Bakai <ab...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] KUDU-3292 Show non-default flags on WEB UI
Posted by "Ádám Bakai (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19408
to look at the new patch set (#2).
Change subject: KUDU-3292 Show non-default flags on WEB UI
......................................................................
KUDU-3292 Show non-default flags on WEB UI
Change-Id: Iac723646389d20bd5dbac41524d3a495355387ae
---
M src/kudu/server/default_path_handlers.cc
M src/kudu/util/flag_tags-test.cc
M src/kudu/util/flags.cc
M src/kudu/util/flags.h
4 files changed, 40 insertions(+), 23 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/08/19408/2
--
To view, visit http://gerrit.cloudera.org:8080/19408
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iac723646389d20bd5dbac41524d3a495355387ae
Gerrit-Change-Number: 19408
Gerrit-PatchSet: 2
Gerrit-Owner: Ádám Bakai <ab...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-3292 Show non-default flags on WEB UI
Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/19408 )
Change subject: KUDU-3292 Show non-default flags on WEB UI
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/19408
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iac723646389d20bd5dbac41524d3a495355387ae
Gerrit-Change-Number: 19408
Gerrit-PatchSet: 3
Gerrit-Owner: Ádám Bakai <ab...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Tue, 10 Jan 2023 15:54:33 +0000
Gerrit-HasComments: No