You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/09/27 22:33:37 UTC

[GitHub] [ozone] errose28 commented on a diff in pull request #3750: HDDS-7217. OM logs wrong bucket layout

errose28 commented on code in PR #3750:
URL: https://github.com/apache/ozone/pull/3750#discussion_r981779944


##########
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/request/TestOMClientRequestWithUserInfo.java:
##########
@@ -95,7 +96,8 @@ public void testUserInfo() throws Exception {
     String volumeName = UUID.randomUUID().toString();
     OzoneManagerProtocolProtos.OMRequest omRequest =
         OMRequestTestUtils.createBucketRequest(bucketName, volumeName, true,
-            OzoneManagerProtocolProtos.StorageTypeProto.DISK);
+            OzoneManagerProtocolProtos.StorageTypeProto.DISK,
+            ClientVersion.DEFAULT_VERSION.toProtoValue());

Review Comment:
   If a version needs to be specified, the latest version should be used, not the earliest, unless this is doing client cross compat testing, which I don't think it is. That would be `ClientVersion.CURRENT`



##########
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/request/TestOMClientRequestWithUserInfo.java:
##########
@@ -95,7 +96,8 @@ public void testUserInfo() throws Exception {
     String volumeName = UUID.randomUUID().toString();
     OzoneManagerProtocolProtos.OMRequest omRequest =
         OMRequestTestUtils.createBucketRequest(bucketName, volumeName, true,
-            OzoneManagerProtocolProtos.StorageTypeProto.DISK);
+            OzoneManagerProtocolProtos.StorageTypeProto.DISK,
+            ClientVersion.DEFAULT_VERSION.toProtoValue());

Review Comment:
   Why is this change concerned with client version?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org