You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@tez.apache.org by "Vasanth kumar RJ (JIRA)" <ji...@apache.org> on 2015/04/11 23:06:12 UTC

[jira] [Comment Edited] (TEZ-2309) Fix slf4j dependencies for tez modules

    [ https://issues.apache.org/jira/browse/TEZ-2309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14491197#comment-14491197 ] 

Vasanth kumar RJ edited comment on TEZ-2309 at 4/11/15 9:05 PM:
----------------------------------------------------------------

tez-api's TezClientUtils.java has log level check using org.apache.log4j.Level. Level checks cannot be done from slf4j.

 In tez-common has log4j NDC in CallableWithNdc and FileAppender in TezContainerLogAppender. slf4j is a abstraction for logging framework. We can delegate all to slf4j using log4j-over-slf4j but it does not work for custom appender seems. Reference http://slf4j.org/legacy.html#log4j-over-slf4j



was (Author: vasanthkumar):
tez-api's TezClientUtils.java has log level check using org.apache.log4j.Level. Level checks cannot be done from slf4j.

 In tez-common has log4j NDC in CallableWithNdc and FileAppender in TezContainerLogAppender. slf4j is a abstraction for logging framework. We can delegate all 

> Fix slf4j dependencies for tez modules 
> ---------------------------------------
>
>                 Key: TEZ-2309
>                 URL: https://issues.apache.org/jira/browse/TEZ-2309
>             Project: Apache Tez
>          Issue Type: Bug
>            Reporter: Hitesh Shah
>            Priority: Critical
>         Attachments: TEZ-2309.1.patch
>
>
> Most modules should depend only on slf4j-api and not slf4j-log4j12. 
> I believe only tez-dag and tez-runtime-internals might need the log4j dependency due to log rotation related code.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)